Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrated terminal does not render Truecolor. #18544

Closed
jordwalke opened this issue Jan 14, 2017 · 4 comments · Fixed by #73599
Closed

Integrated terminal does not render Truecolor. #18544

jordwalke opened this issue Jan 14, 2017 · 4 comments · Fixed by #73599
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality on-testplan terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone
May 2019

Comments

@jordwalke
Copy link

  • VSCode Version:
    Insiders build as of now.
  • OS Version:
    mac Sierra

Steps to Reproduce:

curl https://raw.githubusercontent.com/JohnMorales/dotfiles/master/colors/24-bit-color.sh > testColors.sh
2. sh testColors.sh

You will see that it does not render all of the colors, and instead appears to only render 256.
@dbaeumer dbaeumer added the terminal General terminal issues that don't fall under another label label Jan 16, 2017
@Tyriar Tyriar mentioned this issue Jan 16, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented Jan 16, 2017

Created upstream issue xtermjs/xterm.js#484

@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jan 16, 2017
@mousetraps mousetraps mentioned this issue Jan 24, 2017
Closed
@Tyriar
Copy link
Member

Tyriar commented Apr 21, 2017

Related #24620

@joerideg
Copy link

joerideg commented May 4, 2019

Hi,
xtermjs/xterm.js#1895
this was merged 27days ago. Any clue when this would hit vscode?
cheers

@Tyriar
Copy link
Member

Tyriar commented May 4, 2019 •
edited
Loading

@joerideg because of the remote release this was too risky of a change to pull in for April (there are also still bugs around it that need to be fixed). It will likely get pulled in for the May release.

@Tyriar Tyriar added this to the May 2019 milestone May 4, 2019
@Tyriar Tyriar mentioned this issue May 13, 2019
Merged
10 tasks
@Tyriar Tyriar mentioned this issue May 28, 2019
Closed
2 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality on-testplan terminal General terminal issues that don't fall under another label upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
May 2019
Development

Successfully merging a pull request may close this issue.

Update vscode-xterm microsoft/vscode
4 participants
@jordwalke @dbaeumer @Tyriar @joerideg