Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a setting for case sensitive sorting in explorer #18622

Closed
fungl164 opened this issue Jan 16, 2017 · 7 comments
Closed

Add a setting for case sensitive sorting in explorer #18622

fungl164 opened this issue Jan 16, 2017 · 7 comments
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality file-explorer Explorer widget issues

Comments

@fungl164
Copy link

fungl164 commented Jan 16, 2017

  • VSCode Version: Version 1.8.1 (1.8.1)
  • OS Version: OSX 10.12.2

Steps to Reproduce:

  1. Open VS Code
  2. Open project folder
  3. Open file explorer
  4. Review File Tree

Looks like it's caused by this in vscode/src/vs/base/common/comparers.ts (line 10):

const FileNameComparer = new Intl.Collator(undefined, { numeric: true, sensitivity: 'base' });

could be changed to:

const FileNameComparer = new Intl.Collator(undefined, { numeric: true, sensitivity: 'case' });

or

const FileNameComparer = new Intl.Collator(undefined, { numeric: true, sensitivity: 'variant' });

Ideally this would be controlled in the user/workspace settings...

In the mean time, is there a way to manually change this in my local running copy? Thnxs!

@dbaeumer dbaeumer added the file-explorer Explorer widget issues label Jan 16, 2017
@bpasero
Copy link
Member

bpasero commented Jan 17, 2017

@fungl164 can you give a concrete example where you expect a certain order and you do not see it?

@bpasero bpasero added the info-needed Issue requires more information from poster label Jan 17, 2017
@bpasero bpasero added this to the Backlog milestone Jan 17, 2017
@bpasero
Copy link
Member

bpasero commented Jan 17, 2017

It seem native at least on macOS to ignore casing:

image

@fungl164
Copy link
Author

Thnxs @bpasero,

When case sensitivity is on, I would expect to see:

  • out
  • outb
  • outd
  • Outa
  • Outc

Are you saying the behavior you describe only happens on OSX? Thnxs...

@bpasero bpasero changed the title File explorer's filename comparison not case sensitive Add a setting for case sensitive sorting in explorer Jan 17, 2017
@bpasero bpasero added feature-request Request for new features or functionality and removed info-needed Issue requires more information from poster labels Jan 17, 2017
@bpasero bpasero removed their assignment Jan 17, 2017
@bpasero bpasero removed this from the Backlog milestone Jan 17, 2017
@bpasero
Copy link
Member

bpasero commented Jan 17, 2017

No, on all platforms.

@soulomoon
Copy link

would really appreciate if treating order as the way Github did

@dlech
Copy link
Contributor

dlech commented Feb 9, 2017

can you give a concrete example where you expect a certain order and you do not see it?

I know this is not the same as what the OP is requesting, but this is the order I would expect to see...

GitHub and Sublime text (among others) list files and folders starting with capital letters first, then lower case. An example where this is useful is the Linux kernel. For example, the Documentation folder is listed first, then other folders (example), likewise, in other directories, the Makefile and Kconfig are listed first, then other files (example).

It really makes finding these "special" files easier instead of having in the middle of all of the "regular" files. Many other projects use this type of folder/file naming for organization as well.

So, if an option is added, this should be one of the options.

@bpasero
Copy link
Member

bpasero commented May 31, 2017

Merging this issue into #27759

@bpasero bpasero closed this as completed May 31, 2017
@bpasero bpasero added the *duplicate Issue identified as a duplicate of another issue(s) label May 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality file-explorer Explorer widget issues
Projects
None yet
Development

No branches or pull requests

5 participants