Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diff Editor 2: wrong displayed region when switching "diffEditor.ignoreTrimWhitespace" #187820

Closed
hansu opened this issue Jul 13, 2023 · 4 comments
Closed

Diff Editor 2: wrong displayed region when switching "diffEditor.ignoreTrimWhitespace" #187820

hansu opened this issue Jul 13, 2023 · 4 comments
Assignees
@hediet
Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues *duplicate Issue identified as a duplicate of another issue(s)
Milestone
December / Januar...

Comments

@hansu
Copy link

hansu commented Jul 13, 2023

  1. View a diff with "diffEditor.ignoreTrimWhitespace": false --> everything is okay
  2. Set "diffEditor.ignoreTrimWhitespace": true --> there is a region which is not hidden:

vscode-diff-edotor-2_bug

Closing the diff and re-opening resolves it.
@hansu
Copy link
Author

hansu commented Jul 13, 2023

@hediet

@hansu hansu mentioned this issue Jul 13, 2023
Closed
@hediet hediet added diff-editor Diff editor issues under-discussion Issue is under discussion for relevance, priority, approach bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jul 13, 2023
@hediet hediet self-assigned this Jul 13, 2023
@hediet
Copy link
Member

hediet commented Jul 13, 2023 •
edited
Loading

I think this is caused by the logic that tries to keep text visible.
Related to #187690

Do you have reproduction steps?

@hediet hediet added this to the Backlog milestone Jul 13, 2023
@hansu
Copy link
Author

hansu commented Jul 13, 2023

Do you have reproduction steps?

  1. Clone that repository with the given branch: https://github.com/smoe/linuxcnc/tree/docs29_mac_103
  2. Diff with becd9ba6a3dfe555680cb3e5c9adf9e3046a6d57
  3. Have a look at gladevcp.adoc around line 2665

@hediet hediet mentioned this issue Jun 27, 2023
Closed
@hediet
Copy link
Member

hediet commented Dec 6, 2023

/duplicate #187844

@hediet hediet closed this as not planned Won't fix, can't repro, duplicate, stale Dec 6, 2023
@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hediet hediet

Labels
bug Issue identified by VS Code Team member as probable bug diff-editor Diff editor issues *duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Milestone
December / January 2024
Development

No branches or pull requests
5 participants
@hediet @alexdima @aiday-mar @hansu @vscodenpa