Improve perf of notebook search

[andreamah]

This issue is here to track cleanup of closed notebook search (#173726).

Notably, this includes:

• Trying to reduce the communication between ext host and renderer processes to improve perf in remote.
• Other small optimizations (ie: file matching improvements)
  • implement closed-notebook search #174287 (comment)
  • implement closed-notebook search #174287 (comment)

[andreamah]

Note: we should be aware of how many calls to the ext host we make; with the current implementation, we make one call per notebook, but this can be quite bad in remote scenarios.

vscode/src/vs/workbench/contrib/search/browser/notebookSearchService.ts

Line 84 in 26f41a4

_data = await serializer.dataToNotebook(bytes);

[andreamah]

Ideally, there would be another ext host function adjacent to this one that takes a mapping of URI to VSBuffer and multiple buffers can be handled at once.

vscode/src/vs/workbench/api/common/extHostNotebook.ts

Lines 292 to 299 in 26f41a4

	async $dataToNotebook(handle: number, bytes: VSBuffer, token: CancellationToken): Promise<SerializableObjectWithBuffers<NotebookDataDto>> {
	const serializer = this._notebookSerializer.get(handle);
	if (!serializer) {
	throw new Error('NO serializer found');
	}
	const data = await serializer.serializer.deserializeNotebook(bytes.buffer, token);
	return new SerializableObjectWithBuffers(typeConverters.NotebookData.from(data));
	}

This would require changing ExtHostNotebookShape.

vscode/src/vs/workbench/api/common/extHost.protocol.ts

Lines 2315 to 2322 in 7a932b9

	export interface ExtHostNotebookShape extends ExtHostNotebookDocumentsAndEditorsShape {
	$provideNotebookCellStatusBarItems(handle: number, uri: UriComponents, index: number, token: CancellationToken): Promise<INotebookCellStatusBarListDto | undefined>;
	$releaseNotebookCellStatusBarItems(id: number): void;
	$dataToNotebook(handle: number, data: VSBuffer, token: CancellationToken): Promise<SerializableObjectWithBuffers<NotebookDataDto>>;
	$notebookToData(handle: number, data: SerializableObjectWithBuffers<NotebookDataDto>, token: CancellationToken): Promise<VSBuffer>;
	$saveNotebook(handle: number, uri: UriComponents, versionId: number, options: files.IWriteFileOptions, token: CancellationToken): Promise<INotebookPartialFileStatsWithMetadata>;
	}

[andreamah]

Fixed by #192358