-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow specifying prompt prefix via Environment variable collection #188969
Comments
There's been a lot of behind the scenes discussions on this, here's a summary of what we've considered:
|
Terminal prompts are generally used to indicate whether a Python env is currently activated in terminal: There's generally a shell specific variable which can be set to do this, but powershell and fish have a concept of prompt functions instead which have to modified by running a script instead to set the prompt. We're fine with fish not indicating if an env is activated given it's not used as much, but powershell is the windows default which is slightly more concerning. |
Since we had differing opinions, we brought this issue of prompt prefix vs inconsistent environment activation to the UX sync, to get a final decision and commit to it. Here's what we discussed:
So the final decision is:
@karrtikr can you create an issue to track this new work for the Python extension and we can then close this issue out. |
Thanks, created microsoft/vscode-python#21793. |
We had planned something similar earlier: microsoft/vscode-python#21793 (comment) but did not go with it. Do you think this helps, or should we explicitly add the name of current env ( cc/ @cwebster-99 @luabud |
Here's what I'm currently thinking:
We can move "You can hover over the terminal tab to get information about the activation" into the "Learn more" doc. |
If we add the name of the environment:
|
Those changes would help, especially adding the environment to catch my eye since that's what I look for to see if an env is activated. |
The notification change makes sense to me! And the idea is that it'd show the name of the currently selected environment, right? |
The idea is to use shell integration to apply this parameter. This can be used by Python extension to indicate an environment is activated in Powershell or fish where there is no other way to set the prompt.
The text was updated successfully, but these errors were encountered: