Stop doesn't kill debugged restart app

[joaomoreno]

Testing #19040

1. Create Nodemon debug sample
2. F5
3. Hit stop

The terminal will read

[nodemon] app crashed - waiting for file changes before starting...

Which indicates nodemon is still running, when it shouldn't.

The problem aggravates once the user presses F5 again: nothing happens because some input is sent to the Terminal, but it's nodemon and not the shell that handles it. To get out of this state, the user must go to the terminal and Ctrl C.

Also, in that stopped state, a change in the JavaScript file will restart the server, since nodemon is still running.

[weinand]

@joaomoreno VS Code does not try to control (terminate) 'nodemon' because its lifecycle is typically longer than that of the debuggee. So pressing the Terminate button only terminates the debuggee but leaves nodemon alone.

This issue is documented for the 'attach' case here: https://code.visualstudio.com/docs/editor/node-debugging#_attaching-to-nodejs:

Tip: Pressing the Stop button stops the debug session and disconnects from Node.js, but nodemon (and Node.js) will continue to run. To stop nodemon, you will have to kill it from the command line.

We will have to update the doc for the 'launch' case.

[weinand]

IMO the doc explains this case sufficiently.

We cannot improve the implementation (and kill nodemon) because we do not know the process ID of nodemon since it was started from an integrated terminal.