Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlights flicker when clicking on them #196355

Closed
jrieken opened this issue Oct 24, 2023 · 3 comments · Fixed by #196642
Closed

Highlights flicker when clicking on them #196355

jrieken opened this issue Oct 24, 2023 · 3 comments · Fixed by #196642
Assignees
@Yoyokrazy
Labels
bug Issue identified by VS Code Team member as probable bug editor-highlight Editor selection/word highlight issues important Issue identified as high-priority verified Verification succeeded
Milestone
October 2023

Comments

@jrieken
Copy link
Member

jrieken commented Oct 24, 2023 •
edited
Loading

Testing #196342

  • enable editor.multiDocumentOccurrencesHighlight
  • open src/vs/workbench/contrib/inlineChat/common/inlineChatServiceImpl.ts and src/vs/workbench/contrib/inlineChat/common/inlineChat.ts side by side
  • select IInlineChatSessionProvider
  • click on occurrences
  • 🐛 whenever an occurrence is selected for the first time all highlights disappear and reappear

This also happens in the single document highlight case and I am sure is a regression
@Yoyokrazy Yoyokrazy added the important Issue identified as high-priority label Oct 25, 2023
@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Oct 25, 2023 •
edited
Loading

Looks like this is fixed with #196642. Seems like two birds, one stone. Cannot repro in OSS with latest main.

Insiders behavior (broken)
https://github.com/microsoft/vscode/assets/12552271/edbae45c-6998-4b5e-9e31-2a076c91179d

latest OSS (fixed)
https://github.com/microsoft/vscode/assets/12552271/8e872601-29a7-4db0-a3a4-27bfbffd2c2f

@Yoyokrazy Yoyokrazy linked a pull request Oct 25, 2023 that will close this issue
Fix#196597 word highlighter decoration not being set #196642
Merged
@Yoyokrazy Yoyokrazy added the bug Issue identified by VS Code Team member as probable bug label Oct 26, 2023
@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Oct 26, 2023 •
edited
Loading

bug label for verification

@alexdima
Copy link
Member

@Yoyokrazy Also the milestone should be set.

@alexdima alexdima added this to the October 2023 milestone Oct 26, 2023
@meganrogge meganrogge added the verified Verification succeeded label Oct 26, 2023
@Yoyokrazy Yoyokrazy added the editor-highlight Editor selection/word highlight issues label Nov 7, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

Labels
bug Issue identified by VS Code Team member as probable bug editor-highlight Editor selection/word highlight issues important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
October 2023
Development

Successfully merging a pull request may close this issue.

Fix#196597 word highlighter decoration not being set microsoft/vscode
4 participants
@jrieken @alexdima @Yoyokrazy @meganrogge