Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings change does not preserve highlights on the recently interacted model #196356

Closed
jrieken opened this issue Oct 24, 2023 · 2 comments · Fixed by #224243
Closed

Settings change does not preserve highlights on the recently interacted model #196356

jrieken opened this issue Oct 24, 2023 · 2 comments · Fixed by #224243
Assignees
@Yoyokrazy
Labels
editor-highlight Editor selection/word highlight issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2024

Comments

@jrieken
Copy link
Member

jrieken commented Oct 24, 2023

Testing #196342

  • have settings editor, and two code editors that show some symbols (e.g src/vs/workbench/contrib/inlineChat/common/inlineChat.ts and src/vs/workbench/contrib/inlineChat/common/inlineChatServiceImpl.ts)
  • enable x-model highlights
  • select a symbols that get highlighted across editors
  • disable x-model highlights
  • 😕 highlights in both editors disappear, it would be cool if the most recent editor could keep the highlights
  • the same is true when enabling the setting again
@Yoyokrazy Yoyokrazy added the editor-highlight Editor selection/word highlight issues label Nov 7, 2023
@Yoyokrazy Yoyokrazy added the feature-request Request for new features or functionality label Dec 14, 2023
@Yoyokrazy Yoyokrazy mentioned this issue Jul 29, 2024
Merged
@Yoyokrazy
Copy link
Contributor

Yoyokrazy commented Jul 30, 2024 •
edited
Loading

wordHighlighter will trigger a this._run() for each open and visible editor. also triggers a _stopAll() for one of these workerRequests.

need to iron out the behavior with one of the editors as the "driver"

@Yoyokrazy Yoyokrazy added this to the August 2024 milestone Jul 30, 2024
@Yoyokrazy Yoyokrazy changed the title Settings change handling could be improved Settings change does not preserve highlights on the recently interacted model Jul 30, 2024
@Yoyokrazy Yoyokrazy mentioned this issue Jul 30, 2024
Closed
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Jul 30, 2024
@vs-code-engineering vs-code-engineering bot removed the unreleased Patch has not yet been released in VS Code Insiders label Jul 31, 2024
@vs-code-engineering VS Code Engineering
Copy link 

		Issue marked as unreleased but unable to locate closing commit in issue timeline. You can manually reference a commit by commenting `\closedWith someCommitSha`, or directly add the `insiders-released` label if you know this has already been releaased

@vs-code-engineering vs-code-engineering bot added unreleased Patch has not yet been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Jul 31, 2024
@Yoyokrazy Yoyokrazy added the verification-needed Verification of issue is requested label Aug 28, 2024
@connor4312 connor4312 added the verified Verification succeeded label Aug 28, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Yoyokrazy Yoyokrazy

Labels
editor-highlight Editor selection/word highlight issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2024
Development

Successfully merging a pull request may close this issue.

Preserve highlights switching between single/multi file highlights microsoft/vscode
4 participants
@jrieken @connor4312 @Yoyokrazy @vscodenpa