Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote notebookKernelSource API proposal to stable #197471

Open
tomqwpl opened this issue Nov 5, 2023 · 3 comments
Open

Promote notebookKernelSource API proposal to stable #197471

tomqwpl opened this issue Nov 5, 2023 · 3 comments
Assignees
Labels
notebook-api under-discussion Issue is under discussion for relevance, priority, approach

Comments

@tomqwpl
Copy link
Contributor

tomqwpl commented Nov 5, 2023

There is a proposed API called notebookKernelSource. This seems to have been introduced for and indeed is in active use by the MS Jupyter extension.
I would like to use this API extension to do the same thing as the Jupyter extension, get involved in the notebook kernel selection process. Since this is a proposed API, as a third party developer I can't make use of it, whereas Microsoft published extensions can through the "extensionEnabledApiProposals" mechanism in the VSCode "product.json" file.

Since this API is now in use by a published extension, even a Microsoft published one, changing it would be hard. However, since it is only in use by a Microsoft published extension, and those can use proposed APIs, there seems to be no incentive to promote this to stable. I'm hoping that this is because no one has asked for it to be promoted rather than for any other reason of competitive advantage for example.

It's slightly unclear from the wiki page exactly what the process is by which an API proposal gets promoted. If this isn't an appropriate way, then please let me know and point me at the appropriate mechanism.

Pinging @rebornix and @DonJayamanne in the first instance as they are the two committers of the dts file.

@gjsjohnmurray
Copy link
Contributor

The way I interpret the November iteration plan at #197438, finalization will happen this month.

@tomqwpl
Copy link
Contributor Author

tomqwpl commented Nov 5, 2023

@gjsjohnmurray That certainly looks plausible, and that's good news if that's the case. It at least means I can have code developed and ready that makes use of it.
Thanks.

@aiday-mar aiday-mar assigned rebornix and unassigned aiday-mar Nov 6, 2023
@rebornix rebornix added under-discussion Issue is under discussion for relevance, priority, approach notebook labels Nov 17, 2023
@ehassaan
Copy link

Is there any plan to promote this API to stable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook-api under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

7 participants