Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal sticky scroll flickers #198446

Closed
jrieken opened this issue Nov 16, 2023 · 4 comments
Closed

Terminal sticky scroll flickers #198446

jrieken opened this issue Nov 16, 2023 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal-sticky-scroll

Comments

@jrieken
Copy link
Member

jrieken commented Nov 16, 2023

Sorry, no real steps except for using the terminal and its sticky scroll at lot. There seems to be some condition that makes sticky scroll jump around. This doesn't reproduce reliable but often enough to be a pain. Please let me know what debug settings and logs there are to make this a good bug

Screen.Recording.2023-11-16.at.16.26.26.mov
@Tyriar
Copy link
Member

Tyriar commented Nov 16, 2023

Looks like it's caused by the empty line on top:

image

I may have just fixed this as part of #198463, specifically removing the - 1 from this line:

if ((this.commands[i].promptStartMarker ?? this.commands[i].marker!).line <= line - 1) {

If that doesn't fix it in tomorrow's build, could you set "terminal.integrated.developer.devMode": true and try repro again? Also helpful are debug logs when the commands are printed from the Terminal output channel.

@Tyriar Tyriar added the info-needed Issue requires more information from poster label Nov 16, 2023
@vscodenpa
Copy link

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Nov 24, 2023
@jrieken jrieken reopened this Nov 24, 2023
@jrieken jrieken removed the info-needed Issue requires more information from poster label Nov 24, 2023
@joyceerhl joyceerhl added bug Issue identified by VS Code Team member as probable bug terminal-sticky-scroll labels Dec 15, 2023
@Tyriar
Copy link
Member

Tyriar commented Dec 10, 2024

This was waiting for info needed:

If that doesn't fix it in tomorrow's build, could you set "terminal.integrated.developer.devMode": true and try repro again? Also helpful are debug logs when the commands are printed from the Terminal output channel.

I've never seen this the whole time I've had it enabled so I need more details on a repro.

@Tyriar Tyriar closed this as completed Dec 10, 2024
@Tyriar Tyriar added the info-needed Issue requires more information from poster label Dec 10, 2024
@jrieken
Copy link
Member Author

jrieken commented Dec 10, 2024

I have stopped using sticky scroll for terminals, but it seems no one else has seen this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug info-needed Issue requires more information from poster terminal-sticky-scroll
Projects
None yet
Development

No branches or pull requests

4 participants