Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet is working(only p is not working) #20531

Closed
wikilike7 opened this issue Feb 13, 2017 · 5 comments
Closed

Emmet is working(only p is not working) #20531

wikilike7 opened this issue Feb 13, 2017 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues

Comments

@wikilike7
Copy link

  • VSCode Version: 19.1
  • OS Version: Win 7 x64

Steps to Reproduce:

  1. when i enter p then press tab only doctype apprea
  2. if i use p*1 is working, other code like h1 h2 div etc also.

image

@egamma
Copy link
Member

egamma commented Feb 20, 2017

Actually emmet expands properly you can see this when you expand p using the command Emmet: Expand Abbreviation from the command palette.

The issue is that p has word/quick suggestions (e.g. DOCTYPE) and pressing TAB commits the suggestion. To avoid this problem you can disable quick suggestions in html by adding the following setting:

    "[html]": {
		"editor.quickSuggestions": false
    }

@ramya-rao-a this is an open issue, one idea would be that emmet abbreviations are also shown in the suggestion pop-up.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Feb 20, 2017

Adding emmet abbreviations to suggestion pop-up would be much simpler to do if emmet integration was done as an extension. This is what is the plan for Emmet 2.0

Regardless, I'll take a look at what it takes to add emmet abbreviations to suggestion pop-up in the current design.

#1952 is tracking this exact issue of suggestion items overlapping with emmet expansions, and the suggestion item winning.

#20716 is tracking something similar for any snippet vs suggestion item.

Therefore closing this in favor of #1952

@ramya-rao-a ramya-rao-a added emmet Emmet related issues *duplicate Issue identified as a duplicate of another issue(s) labels Feb 20, 2017
@egamma
Copy link
Member

egamma commented Feb 23, 2017

@ramya-rao-a regarding

Adding emmet abbreviations to suggestion pop-up would be much simpler to do if emmet integration was done as an extension. This is what is the plan for Emmet 2.0

Rather than adding all emmet abbreviations to the completions list, we could add a single item "Expand emmet abbreviation" to the completion list. This is similar to what is done now for JSDoc expansions. See below. This should be doable with the existing emmet version.

image

@ramya-rao-a
Copy link
Contributor

I didn't mean to add all emmet abbreviations to the completion list. I meant adding just a single one like your example, choosing which the abbreviation will be expanded.

As far as I know, the cleanest way to contribute to the completion list is via extension using the APIs exposed to extensions. The jsdoc expansions are done via the typescript extension.

Of course, there are textual completions that are coming from the core code.

@jrieken Is it recommended to contribute to completion list directly in the core code?

@ramya-rao-a
Copy link
Contributor

See #1952 (comment) to get emmet abbreviations in the completion list

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) emmet Emmet related issues
Projects
None yet
Development

No branches or pull requests

3 participants