-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Emmet is working(only p is not working) #20531
Comments
Actually emmet expands properly you can see this when you expand The issue is that "[html]": {
"editor.quickSuggestions": false
} @ramya-rao-a this is an open issue, one idea would be that emmet abbreviations are also shown in the suggestion pop-up. |
Adding emmet abbreviations to suggestion pop-up would be much simpler to do if emmet integration was done as an extension. This is what is the plan for Emmet 2.0 Regardless, I'll take a look at what it takes to add emmet abbreviations to suggestion pop-up in the current design. #1952 is tracking this exact issue of suggestion items overlapping with emmet expansions, and the suggestion item winning. #20716 is tracking something similar for any snippet vs suggestion item. Therefore closing this in favor of #1952 |
@ramya-rao-a regarding
Rather than adding all emmet abbreviations to the completions list, we could add a single item "Expand emmet abbreviation" to the completion list. This is similar to what is done now for JSDoc expansions. See below. This should be doable with the existing emmet version. |
I didn't mean to add all emmet abbreviations to the completion list. I meant adding just a single one like your example, choosing which the abbreviation will be expanded. As far as I know, the cleanest way to contribute to the completion list is via extension using the APIs exposed to extensions. The jsdoc expansions are done via the typescript extension. Of course, there are textual completions that are coming from the core code. @jrieken Is it recommended to contribute to completion list directly in the core code? |
See #1952 (comment) to get emmet abbreviations in the completion list |
Steps to Reproduce:
p
then presstab
onlydoctype
appreap*1
is working, other code likeh1 h2 div
etc also.The text was updated successfully, but these errors were encountered: