Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @parcel/watcher to 2.5.x #216825

Closed
bpasero opened this issue Jun 21, 2024 · 2 comments
Closed

Update @parcel/watcher to 2.5.x #216825

bpasero opened this issue Jun 21, 2024 · 2 comments
Assignees
Labels
debt Code quality issues file-watcher File watcher
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 21, 2024

For very large mono repos with many TS projects, we see endless loops in the file watcher process (e.g. outlook client) that seem to not reproduce when using @parcel/watcher@2.4.x.

However, there are currently 2 blocking issues with that version:

//cc @deepak1556

@bpasero bpasero added debt Code quality issues file-watcher File watcher labels Jun 21, 2024
@bpasero bpasero added this to the On Deck milestone Jun 21, 2024
@bpasero bpasero self-assigned this Jun 21, 2024
@bpasero bpasero changed the title Update @parcel/watcher to 2.4.x ✋ Update @parcel/watcher to 2.4.x Sep 18, 2024
@bpasero
Copy link
Member Author

bpasero commented Sep 18, 2024

Idea from @deepak1556 as a workaround:

  • Have a git repository that has submodule of parcel on that commit
  • Have @parcel/watcher point to this new git repo
  • In the repo have a package.json two commands in the scripts section
    • install - that would go into the submodule directory and build stuff
    • postinstall - that will copy the contents of the submodule and put them in the root of this git repo so that require works

@bpasero bpasero changed the title ✋ Update @parcel/watcher to 2.4.x Update @parcel/watcher to 2.5.x Nov 4, 2024
@bpasero
Copy link
Member Author

bpasero commented Nov 4, 2024

A new version got released that allows building from source: https://github.com/parcel-bundler/watcher/releases/tag/v2.5.0

We need to add some filter code to ensure we are not shipping the optional dependency though.

@bpasero bpasero modified the milestones: On Deck, January 2025 Nov 4, 2024
@bpasero bpasero closed this as completed Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality issues file-watcher File watcher
Projects
None yet
Development

No branches or pull requests

1 participant