Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Git 2.45] Reftable storage backend is not supported #221642

Closed
jaudiger opened this issue Jul 13, 2024 · 4 comments
Closed

[Git 2.45] Reftable storage backend is not supported #221642

jaudiger opened this issue Jul 13, 2024 · 4 comments
Assignees
Labels
feature-request Request for new features or functionality git GIT issues on-testplan
Milestone

Comments

@jaudiger
Copy link

Does this issue occur when all extensions are disabled?: Yes

VSCode version: 1.91.0
Commit: ea1445c
Date: 2024-07-01T18:53:23.353Z (1 wk ago)
Electron: 29.4.0
ElectronBuildId: 9728852
Chromium: 122.0.6261.156
Node.js: 20.9.0
V8: 12.2.281.27-electron.0
OS: Darwin arm64 23.5.0

Steps to Reproduce

Git 2.45 is needed to reproduce this bug, since it makes use of the new reference storage backend "reftable".

Just clone a git repository with reftable used:

git clone --ref-format=reftable git@github.com:microsoft/vscode.git

Then open the new directory using VSCode. Git information (ie: the git branch) is not displayed correctly:

image

Cloning without reftable, of course, displays the Git information correctly:

image
@VSCodeTriageBot
Copy link
Collaborator

Thanks for creating this issue! It looks like you may be using an old version of VS Code, the latest stable release is 1.91.1. Please try upgrading to the latest version and checking whether this issue remains.

Happy Coding!

@jaudiger
Copy link
Author

Attached the git log from VSCode:
git.log

@lszomoru lszomoru added git GIT issues feature-request Request for new features or functionality labels Jul 15, 2024
@lszomoru lszomoru added this to the Backlog milestone Jul 15, 2024
@lszomoru lszomoru modified the milestones: Backlog, August 2024 Jul 31, 2024
@lszomoru
Copy link
Member

lszomoru commented Aug 5, 2024

@jaudiger, thanks for filing this issue. The latest VS Code Insiders (1.93) contains changes to support the new reftable storage format. I have done preliminary testing but I would really appreciate if you could download it and test the source control functionality and let me know if you see any other issues. Thank you!

@lszomoru lszomoru closed this as completed Aug 5, 2024
@jaudiger
Copy link
Author

jaudiger commented Aug 5, 2024

I just downloaded the latest VSCode Insiders, and it worked like a charm! Thanks for the quick implementation landing inside VSCode!

@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Sep 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality git GIT issues on-testplan
Projects
None yet
Development

No branches or pull requests

3 participants