shell integration onDidStart never stops

[justschen]

Testing #226655

tried testing onDidStartTerminalShellExecution with something simple like writing git status and running it (since it runs by default), but it never stops sending the text via sendText.

maybe this is intended since there is anexplicit onDidEndTerminalShellExecution, but can maybe specify in docs that these two go hand in hand (unless this is already something well known 🫨 )

[Tyriar]

@justschen not sure what you mean by but it never stops sending the text via sendText.?

[justschen]

hmm I actually cannot repro anymore...

for context, I was trying something along the lines of:

	vscode.window.onDidStartTerminalShellExecution(e => {
			if (e.execution.commandLine.value === 'git add .') {
				e.terminal.sendText('git commit -m "auto commit"');
			}
		}),

perhaps e.shellIntegration.executeCommand is the more correct one in this case anyways, but i'll continue playing around with it

[Tyriar]

@justschen my only guess is that commandLine.value may have been different in start and stop? Also something like this is how I would go about doing your example:

// end not start, destructuring
vscode.window.onDidEndTerminalShellExecution({ execution, shellIntegration } => {
    if (execution.commandLine.value === 'git add .') {
        // executeCommand instead of sendText
        shellIntegration.executeCommand('git commit -m "auto commit"');
    }
})

[vs-code-engineering]

We closed this issue because we are unable to reproduce the problem with the steps you describe. Chances are we've already fixed your problem in a recent version of VS Code. If not, please ask us to reopen the issue and provide us with more detail. Our issue reporting guidelines might help you with that.

Happy Coding!