Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

onDidStartTerminalShellExecution not fired when expected #226875

Closed
meganrogge opened this issue Aug 27, 2024 · 1 comment
Closed

onDidStartTerminalShellExecution not fired when expected #226875

meganrogge opened this issue Aug 27, 2024 · 1 comment
Assignees
@Tyriar
Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc.

Comments

@meganrogge
Copy link
Contributor

Testing #226655

I expected to see the start event fire when I press enter, but I do not.

start.mov
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc. labels Aug 27, 2024
@Tyriar Tyriar added this to the August 2024 milestone Aug 27, 2024
@Tyriar
Copy link
Member

Tyriar commented Aug 29, 2024

I think what's happening here is the zsh correction thing happens before the preexec hook goes off. Since started does eventually fire, I don't think we could do anything here if we wanted to.

@Tyriar Tyriar closed this as completed Aug 29, 2024
@Tyriar Tyriar added the *as-designed Described behavior is as designed label Aug 29, 2024
@Tyriar Tyriar removed this from the August 2024 milestone Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tyriar Tyriar

Labels
*as-designed Described behavior is as designed bug Issue identified by VS Code Team member as probable bug terminal-shell-integration Shell integration, command decorations, etc.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Tyriar @meganrogge