Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap with abbreviation in real time #23169

Closed
okram69 opened this issue Mar 24, 2017 · 14 comments
Closed

Wrap with abbreviation in real time #23169

okram69 opened this issue Mar 24, 2017 · 14 comments
Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@okram69
Copy link

okram69 commented Mar 24, 2017

A very useful feature to add to VS Code would be adding emmet wrap with abbreviation in real time.
That I'm aware today it is possible to do that bindings the command "editor.emmet.action.wrapWithAbbreviation" to a shortcut key and it works, but non in real time, you only see the result of your editing when you press Enter

@ramya-rao-a
Copy link
Contributor

So you are saying that you'd like to see the result as you type the abbreviation?

@ramya-rao-a ramya-rao-a added the emmet Emmet related issues label Mar 29, 2017
@okram69
Copy link
Author

okram69 commented Mar 29, 2017

Exactly. It's something that I was used to on my former code editor and would be indeed a really helpful functionality to have.

@ZeroVa
Copy link

ZeroVa commented Mar 29, 2017

This would be very helpful.

@ramya-rao-a ramya-rao-a added the feature-request Request for new features or functionality label Apr 18, 2017
@ramya-rao-a
Copy link
Contributor

@okram69 Can you provide a gif how this worked in your former code editor? Or share which editor was it

@okram69
Copy link
Author

okram69 commented Apr 19, 2017

sublime_text_wrap
And by the way, the code editor was Sublime Text.

@ramya-rao-a
Copy link
Contributor

Thanks! I'll take a look

@ramya-rao-a ramya-rao-a modified the milestones: April 2017, May 2017 Apr 19, 2017
@ramya-rao-a ramya-rao-a modified the milestones: May 2017, Backlog May 31, 2017
@KristjanTammekivi
Copy link

+1, emmet live preview in sublime is the only thing I miss

@ramya-rao-a
Copy link
Contributor

Currently there is no way to listen to events from the input box where you would type the abbreviation.
Once #426 is implemented, we will have the required plumbing to get the "Wrap with abbreviation in real time" feature

@ZeroVa
Copy link

ZeroVa commented Sep 25, 2017

+1
Hoping that happens soon! :) This would help speed up many small tasks. Fixing up my configs recently got Emmet and JSX to play nicely, and it's the happiest I've been with VSCode so far.

@burkeholland
Copy link

Great feature idea! Also requested here https://css-tricks.com/can-vs-code-emmet

@jaegz
Copy link

jaegz commented Dec 5, 2017

+1
One of the most powerful features of ST2/3 + Emmet - this is a must for VS Code!

@ramya-rao-a ramya-rao-a added the help wanted Issues identified as good community contribution opportunities label Feb 5, 2018
@ramya-rao-a ramya-rao-a assigned gushuro and unassigned ramya-rao-a Feb 6, 2018
@ramya-rao-a ramya-rao-a modified the milestones: Backlog, February 2018 Feb 14, 2018
@ramya-rao-a ramya-rao-a removed the help wanted Issues identified as good community contribution opportunities label Feb 14, 2018
@ramya-rao-a
Copy link
Contributor

Turns out we dont need #426 to do this. One of the options passed when creating the input box is a callback that returns the typed text. This can be used to expand the abbreviation in real time.

@ramya-rao-a ramya-rao-a removed this from the February 2018 milestone Feb 27, 2018
@usernamehw
Copy link
Contributor

Wrap Individual Lines with Abbreviation is not covered by live preview.

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 9, 2018

@usernamehw Yes, that's why this issue is not closed yet :) We will include live preview for Wrap Individual Lines with Abbreviation for the March release

Until then, please try out the live preview for the Wrap with Abbreviation command and share feedback

@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Mar 27, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Mar 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators May 10, 2018
@vscodebot vscodebot bot unassigned gushuro May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

9 participants