Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emmet uses the "references" icon #27617

Closed
Tyriar opened this issue May 30, 2017 · 3 comments
Closed

Emmet uses the "references" icon #27617

Tyriar opened this issue May 30, 2017 · 3 comments
Assignees
Labels
emmet Emmet related issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented May 30, 2017

  • VSCode Version: Code - Insiders 1.13.0-insider (c2a17a7, 2017-05-30T05:12:15.312Z)
  • OS Version: Linux x64 4.10.0-21-generic
  • Extensions:
Extension Author Version
EditorConfig EditorConfig 0.9.3
lorem-ipsum Tyriar 1.0.0
sort-lines Tyriar 1.3.0
theme-sapphire Tyriar 0.2.1
vscode-svgviewer cssho 1.4.1
tslint eg2 0.15.0
git-project-manager felipecaputo 1.3.2
md-navigate jrieken 0.0.1
vscode-scss mrmlnc 0.6.2
seti-icons qinjia 0.1.3

#27316

The icon has semantic meaning already that doesn't match when emmet is trying to do:

image

https://code.visualstudio.com/docs/editor/intellisense#_types-of-completions

@Tyriar Tyriar added emmet Emmet related issues ux User experience issues labels May 30, 2017
@ramya-rao-a
Copy link
Contributor

I need an icon that is different from the default "property" icon to differentiation between the suggestion for expanding the abbreviation and the suggestions for autocompleting the abbreviation itself.

Didn't want to introduce a new icon for just emmet.
Could have used the snippet icon, but that means assigning the kind "snippet" which would push the snippets down the list as per editor.snippetSuggestions which had the default value as "bottom" until last release.

Suggestions?

cc @jrieken

@ramya-rao-a ramya-rao-a added the under-discussion Issue is under discussion for relevance, priority, approach label May 31, 2017
@ramya-rao-a ramya-rao-a modified the milestones: May 2017, June 2017 May 31, 2017
@jrieken
Copy link
Member

jrieken commented May 31, 2017

which had the default value as "bottom"

No, the default isn't bottom anymore but inline. We made that change because suggestions are now usually sorted by how well they match the text left of the cursor. The "bottom" and "top" settings only come into play when having no text left of the cursor (in which case emmet won't propose anything I believe)

@ramya-rao-a
Copy link
Contributor

As part of #28556 both type of suggestions are now expanding abbreviations, so there is no need for a different icon anymore

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
emmet Emmet related issues under-discussion Issue is under discussion for relevance, priority, approach ux User experience issues
Projects
None yet
Development

No branches or pull requests

4 participants