Intellisense autocomplete does not work well for JS

[akontsevich]

• VSCode Version: 1.4.2
• OS Version: Linux 4.8.0-58-generic File Search got stuck with a great number of files #63~16.04.1-Ubuntu SMP Mon Jun 26 18:08:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:

1. Created simple bot app with node js (code mentioned below). Auto-complete works fine in line 22 for session parameter.
2. However does not work in line 29 for session parameter (in ReceiveMessage() function) even with JSDoc definitions.

var restify = require('restify');
var builder = require('botbuilder');

// Setup Restify Server
var server = restify.createServer();
server.listen(process.env.port || process.env.PORT || 3978, function () {
   console.log('%s listening to %s', server.name, server.url); 
});

// Create chat connector for communicating with the Bot Framework Service
var connector = new builder.ChatConnector({
    appId: process.env.MICROSOFT_APP_ID,
    appPassword: process.env.MICROSOFT_APP_PASSWORD
});

// Listen for messages from users 
server.post('/api/messages', connector.listen());

// Receive messages from the user and respond by echoing each message back (prefixed with 'You said:')
var dialog = require("./rootdialog")
var bot = new builder.UniversalBot(connector, function (session) {
    session.send("You said: %s", session.message.text);
});

/**
 * @param {Session} {session}
 */
function ReceiveMessage(/*Session*/session) {
    session.send("You said: %s", session.message.text);    
}

VS Code for Node.js Development Quickstart Pack extension installed, does not work without it as well.

Reproduces without extensions: Yes

[mjbvz]

Where is the type Session defined? Is it coming from one of the imported libraries?

[akontsevich]

Yes it comes with botbuilder:
npm install --save botbuilder
npm install --save restify

Defined in file: node_modules/botbuilder/lib/botbuilder.d.ts

[mjbvz]

Try using the module name when referencing types:

/**
 * @param {builder.Session} session
 */
function ReceiveMessage(/*Session*/session) {
    session.send("You said: %s", session.message.text);    
}

Also try enabling JavaScript type checking to track down undefined type references

[akontsevich]

Both does not work: [js] can not find name Session or [js] can not find name builder.

[mjbvz]

Looks like microsoft/TypeScript#11825

These patterns should work:

import * as builder from 'botbuilder';

/**
 * @param {builder.Session} session
 */
function ReceiveMessage(session) {
    session.send("You said: %s", session.message.text);    
}

or

const {Session} = require('botbuilder');

/**
 * @param {Session} session
 */
function ReceiveMessage(session) {
    session.send("You said: %s", session.message.text);    
}

Closing as upstream

[akontsevich]

Thanks! Works.

[akontsevich]

const { IConversationUpdate } = require('botbuilder'); does not work for IConversationUpdate object for some reason.

And if I make
import * as builder from 'botbuilder';
then get error in app.js: Unexpected token import for
var dialog = require("./rootdialog")
where all of above exists. Any other solution?

[akontsevich]

Guys, please reopen this bug as the issue was not solved! Things works fine in IntelliJ IDEA and fails in VS Code.

[mjbvz]

@akontsevich microsoft/TypeScript#11825 is tracking the issue with const { IConversationUpdate } = require('botbuilder');

The unexpected token one seems unrelated. Does this reproduce with all extensions disabled?

[akontsevich]

Yes, reproducible.
/** @param {Session} session */
Still does not work. Works fine in IntelliJ - will stay on it for now.