switching input method to zhuyin would change default key binding of editor.action.commentLine from cmd+/ to ctrl+alt+cmd+/

[up9cloud]

• VSCode Version:v1.13.0
• OS Version:OSX 10.11.6

Steps to Reproduce:

1.switch to Zhuyin input method.
2.ctrl + '/' to comment a line(typo)
2. cmd+/ to comment a line

Reproduces without extensions: No

Tried uninstalling all my extentions, same issue.

With --disable-extensions mode, I can type nothing (the ctrl+/ works) (typo) (the cmd+/ works).
In fact, all my inputs are broken with no extention mode except English input.

my input list

[rebornix]

The comment shortcut is cmd+/ instead of ctrl+/. Can you verify that?

[up9cloud]

Yes. it's my typo...
I'll update it.

[up9cloud]

@rebornix is there any good news for this?

[up9cloud]

@alexandrudima , @rebornix

i figure out why...
when i switch to input US, the default key of editor.action.commentLine is cmd+/
when i switch to input Zhuyin, the default key of editor.action.commentLine would be ctrl+alt+cmd+/

so i solve this issue by set keybindings.json to

[
  {
    "key": "cmd+[Slash]",
    "command": "editor.action.commentLine",
    "when": "editorTextFocus && !editorReadonly"
  },
  {
    "key": "ctrl+alt+cmd+[Slash]",
    "command": "-editor.action.commentLine",
    "when": "editorTextFocus && !editorReadonly"
  }
]

dose it work as expected?

[alexdima]

@up9cloud The keyboard engine does the following with a default keybinding on OSX.

Let's consider cmd + /:

• it will search for your current keyboard layout all possible keypresses and determine what character gets produced.
• Under the US layout, [Slash] produces the /. The keybinding will be cmd+[Slash].
• Under the DE layout, shift + [Digit7] produces the /. The keybinding will be cmd+shift+[Digit7].
• I assume ctrl + alt + [Slash] produces the / under the Zhuyin keyboard layout. This can be verified by opening an editor and running F1 > Developer: Inspect Key Mappings. The keybinding will be ctrl+alt+cmd+[Slash].

It is perhaps unfortunate, but it tries to do the best it can given the plethora of keyboard layouts. You can upvote that we ship with keyboard layout optimized default keybindings in #1240

[up9cloud]

@alexandrudima

the keybinding based on keyboard layout might cause issue here, because of

the zhuyin input has 2 mode

• [caps lock] button off: this is zhuyin input with chinese mode
  • press [Slash] it will produce ㄥ
  • press ctrl + [Slash] it will produce ／
  • press ctrl + alt + [Slash] it will produce ／
  • press alt + [Slash] it will produce ／
  • press shift + [Slash] it will produce ？
  • press ctrl + shift + [Slash] it will produce ／
  • press alt + shift + [Slash] it will produce ？
• [caps lock] button on: this is zhuyin input with english mode
  • press [Slash] it will produce / **<= should work? **
  • press ctrl + [Slash] it will produce ``
  • press ctrl + alt + [Slash] it will produce /
  • press alt + [Slash] it will produce /
  • press shift + [Slash] it will produce ?
  • press ctrl + shift + [Slash] it will produce ``
  • press alt + shift + [Slash] it will produce ?

the F1 > Developer: Inspect Key Mappings

zhuyin chinese mode

...
	"Slash": {
		"value": "ㄥ",
		"valueIsDeadKey": false,
		"withShift": "?",
		"withShiftIsDeadKey": false,
		"withAltGr": "/",
		"withAltGrIsDeadKey": false,
		"withShiftAltGr": "?",
		"withShiftAltGrIsDeadKey": false
	},
...

zhuyin english mode

...
	"Slash": {
		"value": "ㄥ",
		"valueIsDeadKey": false,
		"withShift": "?",
		"withShiftIsDeadKey": false,
		"withAltGr": "/",
		"withAltGrIsDeadKey": false,
		"withShiftAltGr": "?",
		"withShiftAltGrIsDeadKey": false
	},
...