Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal Switcher: Rename terminal should be populated and have selection #31840

Closed
kieferrm opened this issue Aug 1, 2017 · 0 comments · Fixed by #31871
Closed

Terminal Switcher: Rename terminal should be populated and have selection #31840

kieferrm opened this issue Aug 1, 2017 · 0 comments · Fixed by #31871
Assignees
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Milestone

Comments

@kieferrm
Copy link
Member

kieferrm commented Aug 1, 2017

While testing #31784.

  • VSCode Version: Code - Insiders 1.15.0-insider (f39385b, 2017-08-01T05:07:59.267Z)
  • OS Version: Darwin x64 16.7.0

Steps to Reproduce:

  1. Open a terminal
  2. Select Terminal: Switch Active Terminal from the command palette
  3. ArrowDown to the terminal in the switcher
  4. Move keyboard focus to rename action using 2 Tabs. See Terminal Switcher: Rename should be reachable with first tab #31835.
  5. Enter to enter rename mode
    -> text box is empty. This is fine if I want to assign a completely new name, but an issue if I only want to correct a typo for example. The input box should contain the old name and the name should be selected so that I can start typing to replace or use Arrow keys to get to the right place to correct the typo.
@kieferrm kieferrm added feature-request Request for new features or functionality terminal Integrated terminal issues labels Aug 1, 2017
@vscodebot vscodebot bot added the insiders label Aug 1, 2017
@Lixire Lixire added this to the July 2017 milestone Aug 1, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants