Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Keeping the undo history when the file changes on disk #33302

Closed
2 tasks done
alexdima opened this issue Aug 28, 2017 · 1 comment
Closed
2 tasks done

Test: Keeping the undo history when the file changes on disk #33302

alexdima opened this issue Aug 28, 2017 · 1 comment

Comments

@alexdima
Copy link
Member

alexdima commented Aug 28, 2017

Test plan item for #2908 (PR #29655)

Complexity: 3


Test that if you do some changes on a file and save the file, and then the file gets changed on disk via some other program, we (as before) automatically update to show the disk content, but (unlike before) the undo stack is maintained.

Some edge cases:

  • a large (log-style) file with a program that logs to it every N seconds. Please check that we don't run OOM due to the undo stack.
  • a change on disk that is large (goes from a file to an empty file, goes from an empty file to a file with 20MB, etc.)
@alexdima alexdima added this to the August 2017 milestone Aug 28, 2017
@aeschli
Copy link
Contributor

aeschli commented Aug 29, 2017

Tested on Linux:

  • open a file in VSCode, make several change, test undo and redo
  • modify the file in an other editor, see that changes are applied to editor in VSCode, test that undo works, also redo
  • test with git viewlet

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants