Mouse Selection now has one line offset in Terminal

[rebornix]

• VSCode Version: 1.16 Insider
• OS Version: macOS

Select on the first line leads to virtual selection on the second line.

Reproduces without extensions: Yes

[Tyriar]

@rebornix do you have zoom level or terminal line height in settings?

[rebornix]

@Tyriar After plug/unplug to my monitor, I can't reproduce anymore. When I ran into that issue, I don't have any zoom, I only set terminal font size and reload the window doesn't work.

Close it right now, If I ran into it again, I'll reopen.

[Tyriar]

Oh I can reproduce, it's definitely a bug. Just curious under which settings you repro'd as there are a few different cases.

[will-l-h]

I have run into this issue as well as ctrl-clicking links in the terminal. window.zoomLevel -1, 0, and 1 are all far enough off to be an issue.

[will-l-h]

I'm on today's update and the issue described here is still present. On zoomLevel 0 it's still shifted a little bit down and on 1 or -1 it's more pronounced.

[darkvertex]

I've updated to the latest code-insiders as of today and I also experience this issue constantly in my Terminal view.

I'm on Linux CentOS 7. code-insiders-1.17.0-1505758214.el7.x86_64

[martellaj]

Any update or extra information needed for this one? It's kind of a killer with respect to using the integrated terminal.

[martellaj]

Thanks, @Tyriar! Can confirm it looks good with today's build!

[darkvertex]

Fixed for me too 🎉 😄 with today's build! - Thanks @Tyriar!

[octref]

I can't repro the original issue so both insider and stable looks fine for me. @Tyriar how should I verify the fix?

[Tyriar]

@octref I would hold off on this until tomorrow as a related issue was closed off.

To verify: Ensure that the mouse cursor selection feels natural, especially as you go further right and further down.