Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search using regex only searches open documents #35232

Closed
SippieCup opened this issue Sep 27, 2017 · 5 comments
Closed

Search using regex only searches open documents #35232

SippieCup opened this issue Sep 27, 2017 · 5 comments
Assignees
Labels
search Search widget and operation issues

Comments

@SippieCup
Copy link

SippieCup commented Sep 27, 2017

  • VSCode Version: Version 1.17.0-insider (Commit 67a8479)
  • OS Version: Linux 4.12.13-1-ARCH Open Source VS Code #1 SMP PREEMPT Fri Sep 15 06:36:43 UTC 2017 x86_64 GNU/Linux

Steps to Reproduce:

  1. Open a folder and ensure all editors are closed.
  2. Open search, enable regex search and search for "\n" - You should get 0 results.
  3. Open a few files in editors and search again, populated results will consist of only the open documents.

Note: sometimes it populates with just a single file, cannot consistently reproduce this.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the insiders label Sep 27, 2017
@vscodebot vscodebot bot added the search Search widget and operation issues label Sep 27, 2017
@chrmarti chrmarti removed the insiders label Sep 27, 2017
@roblourens
Copy link
Member

This is expected - search doesn't normally support multiline search. But if the file is open, then search is done by the editor, which does support multiline search.

@SippieCup
Copy link
Author

Good to know, I thought this was expected behavior but was confused when it did provide a result for the tsconfig.json file in the directory and thought something might have changed/was broken.

screenshot

Is this intended functionality? or is the single result due to tsconfig.json being open in a hidden editor?

@roblourens
Copy link
Member

roblourens commented Sep 27, 2017

That's interesting, I actually don't know why it would do that. It may be a bug in the search tool we use, but not a critical one. I can't reproduce, at least on MacOS

@SippieCup
Copy link
Author

Yeah, definitely not a critical bug, that being said managed to reproduce consistently on MacOS.

  1. Open a folder that has both a .ts file and a tsconfig.json file
  2. Open the .ts file
  3. Close .ts file
  4. Search for "\n" with regex.

@roblourens
Copy link
Member

Ah, I can reproduce it now too. Apparently the tsconfig is open in the background, didn't realize it did that.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

3 participants