Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug fails to recognise the task has failed #3626

Closed
joaomoreno opened this issue Mar 2, 2016 · 3 comments
Closed

Debug fails to recognise the task has failed #3626

joaomoreno opened this issue Mar 2, 2016 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@joaomoreno
Copy link
Member

  • Clone https://github.com/Pure-D/code-d and checkout commit 09ce158566e94bd28cfba9a9fd1365717fa863fd.
  • Open that workspace in Code.
  • Open launch.json and change the outDir values to use ${workspaceRoot}
  • Hit F5

You get this error:

image

Open the task log and you'll see this:

image

Meaning that the npm task failed to execute.

When I run that task in the terminal, I can confirm that it returns a non-zero value. So why isn't Debug picking that up and informing me that the problem occurred in the task itself?

image

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Mar 2, 2016
@isidorn isidorn added this to the March 2016 milestone Mar 2, 2016
@isidorn isidorn closed this as completed in 4a08023 Mar 3, 2016
@isidorn
Copy link
Contributor

isidorn commented Mar 3, 2016

Nice catch and cool repro steps - thanks!

@isidorn isidorn assigned joaomoreno and unassigned isidorn Mar 3, 2016
@isidorn isidorn mentioned this issue Mar 8, 2016
@joaomoreno joaomoreno reopened this Mar 18, 2016
@joaomoreno joaomoreno assigned isidorn and unassigned joaomoreno Mar 18, 2016
@joaomoreno joaomoreno modified the milestones: April 2016, March 2016 Mar 18, 2016
@isidorn
Copy link
Contributor

isidorn commented Mar 24, 2016

After talking to @dbaeumer there is a limitation in the task framework for this.

We need API to provide functionality of running a watch task that would return a TaskSummary both in the success and error case.
Once @dbaeumer adds API I can use it to address this issue, until then -> backlog.

@isidorn isidorn modified the milestones: Backlog, April 2016 Mar 24, 2016
@isidorn isidorn assigned dbaeumer and unassigned isidorn Apr 15, 2016
@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Oct 15, 2019
@isidorn
Copy link
Contributor

isidorn commented Oct 15, 2019

From 2016 -> closing as will not fix, outdated
fyi @alexr00 since there might be a duplicate, or this might have gotten fixed in the meantime

@isidorn isidorn closed this as completed Oct 15, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

4 participants