Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

terminal for task does not realize it's finished if task contains certain clear commands #40034

Closed
joelhock opened this issue Dec 11, 2017 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues

Comments

@joelhock
Copy link

  • VSCode Version: Code 1.18.1 (929bacb, 2017-11-16T18:23:26.125Z)
  • OS Version: Darwin x64 17.3.0
  • Extensions:
Extension Author (truncated) Version

Steps to Reproduce:

  1. create task with:
{
    "version": "2.0.0",
    "tasks": [
        {
            "command": "clear ; echo hi; clear; echo bye",
            "type": "shell",
            "args": [],
            "presentation": {
                "reveal": "always",
                "echo": false,
                "panel": "dedicated"
            },
            "label": "test"
        }
    ]
}
  1. note that when finished terminal does not output Terminal will be reused by tasks, press any key to close it.
  2. try to run task again
  3. vscode complains that task is already running The task 'test (foo)' is already active. To terminate it use 'Terminate Task...' from the Tasks menu.
  4. note that if second clear is removed from the command string, terminal behaves as expected. removing first clear but leaving the second still causes the issue.

This used to work fine; not sure if it was a newer version of vscode or mac OS that broke things.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the tasks Task system issues label Dec 11, 2017
@dbaeumer
Copy link
Member

Dups #37846.

@dbaeumer dbaeumer added the *duplicate Issue identified as a duplicate of another issue(s) label Dec 12, 2017
@vscodebot
Copy link

vscodebot bot commented Dec 12, 2017

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Dec 12, 2017
@joelhock
Copy link
Author

recent insider's build with fix from #37846 does indeed solve this issue. thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) tasks Task system issues
Projects
None yet
Development

No branches or pull requests

2 participants