-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide ability to ignore all whitespace in diff editor (feature request) #43026
Comments
It's been over a year and I REALLY would love to have this feature. Any chance it will be implemented? |
It would be also good if differences in line breaks (not just new/deleted empty lines) could be ignored. That is, the following should be taken to be the same:
|
Ability to Ignore whitespace in Visual Studio Code git diff view for sure will be good feature Looking forward for that |
This would be really helpful! |
As with everything, I have Thoughts On This. I suspect that opinionated formatters such as Prettier solve one problem but at high cost. The problem that formatters solve: whitespace and indentation is consistent across developers and time, so that changes between commits are obvious. This reduces errors and cognitive load when reviewing code and when troubleshooting. Two problems that they aggravate:
A better solution, in my opinion: This is why I support this feature request. As an industry could stand to move away from having opinions about how other developers format their source code, in favor of expressiveness, ease and inclusiveness. |
Hi @rendall, thanks for your comment. While well written, it doesn't seem to add any new specifications or refinements to the feature request. While we all would like this feature to ship, we should respect the time of the maintainers and, as per the contributing guidelines, avoid making comments that simply express a desire for something to be done. If we are not willing to add the feature ourselves and submit a pull request, we must wait and trust in the prioritisation system this team has developed to help bring us this free product we all enjoy. |
Hi Mr. Robinson. Sincerely sorry my opinion rubbed you the wrong way. While I don't mind, the code of conduct emphasizes friendliness and patience. Is there another way you can give feedback? Cheers! |
I do apologise, I have updated my comment to be less caustic. |
Gladly. In case we ever interact again, feel free to share your preferred honorific |
This would be really helpful even three years later! |
@soundneedle, @farmerpaul, @samuelms1, @navneeth-spotnana, @WilliamLHarms This feature already exists in VS code for long now By default now it is enabled to ignore whitespace. If not you can check click on this button to disable "Show Whitespace": You can notice if I enable setting "Show Whitespace", it is showing all whitespace changes too. |
@pranavq212 Thanks! |
That's not quite what people are asking for. It doesn't ignore all whitespace. It ignores leading or trailing whitespace only. |
this is an essential feature, especially when working with libraries from github. |
ignore whitespaces needed!!! :( |
+1 for this feature, please |
+1 Hi VScode team. Your product is great but lacks one this crucial feature. Source reformatting makes diff impossible (irrelevant whitespace changes). Other competing tools (IDEA, WinMerge, TortoiseGit diff etc.) all have ability to ignore ALL whitespaces. Please consider implementing this. |
Hmm. Very interesting. Thank you! Will check now. |
+1 for the option to ignore all white space. |
@hediet you self-assigned this a long time ago, are you working on this? |
@tobiasdiez i created a feature request to ignore line breaks in diff editor see #198381 |
This is really needed please. |
Seriously :) 5 years and counting... |
Not implementing this feature is UNCHRISTIAN |
How dare they, this is AMERICA |
The religious and political side-comments are really unnecessary and unwanted here. They are just noise that you are copying all of the subscribers on this ticket to. Yes, it's horrible that this issue still exists today but smart-alec comments being spammed to every subscriber is not helping at all. Yes, I do realize that I am spamming that same subscriber list but I hope it's useful in that it quells any number of future smart-alec-y comments that provide no help and are of no use. |
It's not America, it's the world. |
I'm probably the only one from our team who is subscribed on this and this noise forced me to unsubscribe... I'm aware of this issue. There are some technical challenges to get good performance for this and currently there are more important issues to work on. |
@hediet, this also affects anyone watching status of any issues. I'd suggest a stronger, organization-wide policy to prohibit this kind of spams and enforce it. If there's any concern that such a drastic measure would alienate users, may I remind that not doing something against these abuses would also alienate other users who behaved civilly, not to mention how this set a bad example to how people should use GitHub generally, making the platform less valuable to developers. I'd suggest you to report higher up to relevant teams to look into this. I don't think it's your responsibility, but definitely Microsoft's. P.S. I recently subscribed because I encountered this issue too. I'm unsubscribing after reading this and those before. |
@ickc You are the spammer here, complete nonsense and off topic. The reaction by users is very predictable given that such a fundamental feature is taking years to implement. |
Although the spam factor is not an issue to me (I disable all email Github notifications or forward all to the same mail folder), I feel like it is healthy that people who think this issue is important enough, be able to comment and contribute. I found finicky to complain about users reasserting their need for a feature. |
People seem to have no GitHub ethics here. Expressing a desire of a feature should use ways that don’t tricker notification to others, such as emoji feedback. This kind of toxic behavior is exactly why there should be policy around this. maintainer, please lock this thread because this is getting uncivil. |
the other option is people got tired of asking... Nike has a nice slogan that fits here |
"Toxic behavior"? Come on. People are using a feature that Github made available for exactly this very ordinary use - for people to express consent or dissatisfaction. There is even emojis for love, to-the-moon, party, etc so we can choose to express ourselves. |
Hey, I saw that issue #198381 got a "VSCodeTriageBot" response and added to the backlog. How do we do that for old issues that existed before the TriageBot? |
so annoying :( |
Think you should just do it, the dev team will never get back to this. |
|
After further searching, I don't think creating a second issue is going to help. The triage-bot only helps with labels (which this already has the correct labels) and whether to put this in the backlog (which has already happened). We just can't compete with 8,000 other requests. I'm going to install a proper diff editor (Meld) and use the "Meld extension." For anyone monitoring this and wondering why we need to ignore all whitespace: imagine where a team applies an auto-formatter to clean up a project. You know, spaces around the equal sign, brace placement, spaces after commas, etc. In VS Code: the diff is a useless sea of red that fails to highlight any real differences. Honestly, I don't even know why a personal would ignore prefix whitespace (which are critical in many files), yet be hard-coded to highlight middle whitespace (almost always safe to ignore. |
Remove fortinet and unblock my websites |
Steps to Reproduce:
"diffEditor.ignoreTrimWhitespace": true
Would it be possible to add
"diffEditor.ignoreAllSpaces": true
? I believe the command-line to achieve this would be something likegit diff --ignore-space-at-eol -b -w [commit]...
h/t Daniel Gomez @ coderwall
[edit]
Might only need
-w
?[/edit]
The text was updated successfully, but these errors were encountered: