Offset of top level tree items changes with icon them change

[sandy081]

From here by @LazarusX

[aeschli]

I think that is the expected result. The whitespace you see is there for twisties.

[LazarusX]

@aeschli Why is the twisty behavior different when switching the file icon theme between Seti and Minimal? In addition, I think the file icon theme setting is not supposed to affect the appearance of extension tree views (see the screen cast in comment: #42097 (comment))

[aeschli]

In general, the goal is to have all labels of the same hierarchy level aligned.
The VSCode Set theme does not have any folder icons. In that case, the file icons are shifted to the left, and align with the twisties of folders at the same level. Best is to try it out with files and folders at the same level.
@sandy081 is looking into the custom trees. which can have user-provided icons as well as file icons from the file icon theme.
IMO, again, the custom tree should make sure, that all labels are aligned.
To do so, the custom tree provider will have to provide placeholder icons for file and folders in case that the current file icon theme does not provide these.
The custom tree provider should also be able to indicate whether

• the tree should always show icons for all items: Placeholders icons have to be used for file/folder/items that don't provide any
• the tree should follow the style of the current file icon theme: No icons, icons only for leafs ('seti' style) or show icons for all items. Again placeholders icons are required for non-file/folder items.

[LazarusX]

Your point regarding the icons in the file explorer makes sense to me.

But for custom trees, it seems that currently there is no way for extensions to respond to file icon theme style changes. In addition, naming it "explorer icon theme" rather than "file icon theme" might better reflect this setting's scope.

[sandy081]

Agreed that custom views should not be concerned about file icon themes. Reopening it

[sandy081]

Fixed by ea78776

[sandy081]

[sandy081]

Reopening it because #28974 (ea78776) is reverted

[sandy081]

Fixed by 11a262e