Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only first TreeView.reveal works #44657

Closed
weinand opened this issue Feb 27, 2018 · 2 comments
Closed

Only first TreeView.reveal works #44657

weinand opened this issue Feb 27, 2018 · 2 comments
Assignees
Labels
info-needed Issue requires more information from poster tree-views Extension tree view issues

Comments

@weinand
Copy link
Contributor

weinand commented Feb 27, 2018

Testing #44364:

My reveal command just calls the TreeView.reveal:

  processViewer.reveal(newItem);
  • If I run this command for the first time, it works fine and it opens a collapsed node to show its child.
  • then I collapse the parent node again
  • If I now use the command a second time, the item is not revealed but I see this error:
    2018-02-27_22-53-46

This problem prevented me from using "reveal" in code that detects model additions and tried to reveal the newly created items.

@sandy081 sandy081 added this to the February 2018 milestone Feb 28, 2018
@sandy081 sandy081 added the tree-views Extension tree view issues label Feb 28, 2018
@sandy081
Copy link
Member

@weinand Can I try to reproduce this using your processes extension?

The error means that the system does not have the node with id 1/27493. Can you check if you are returning this element when getChildren method on your data provider is called?

@sandy081 sandy081 added the info-needed Issue requires more information from poster label Feb 28, 2018
@sandy081 sandy081 removed this from the February 2018 milestone Mar 1, 2018
@vscodebot vscodebot bot closed this as completed Mar 8, 2018
@vscodebot
Copy link

vscodebot bot commented Mar 8, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
info-needed Issue requires more information from poster tree-views Extension tree view issues
Projects
None yet
Development

No branches or pull requests

2 participants