Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smooth scrolling #4606

Closed
nicolasparada opened this issue Mar 23, 2016 · 11 comments · Fixed by #25286
Closed

Smooth scrolling #4606

nicolasparada opened this issue Mar 23, 2016 · 11 comments · Fixed by #25286
Assignees
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality on-testplan
Milestone

Comments

@nicolasparada
Copy link

The scrolling behavior is not smooth when you do it with the mouse wheel. It has been fixed in chromium 49 that comes since electron 0.37.x
So, could you update to the last version of electron?

  • VSCode Version: 0.10.12-insider
  • OS Version: Windows 10

I left a video showing the difference with electron 0.37.x

@mquandalle
Copy link
Contributor

I haven’t look at Chromium49 smooth scrolling yet, but it seems to me that this wouldn’t help VSCode scrolling that is managed using CSS transform3D and absolute positioning.

@nicolasparada
Copy link
Author

Well then, eliminate these approach and use the native scroll behavior in chromium >= 49.

@jhasse
Copy link
Contributor

jhasse commented Apr 13, 2016

Just tried out latest master: This is indeed not fixed in VSCode simply by updating to electron 0.37.5.

@alexdima
Copy link
Member

@mquandalle is correct, we own the scrolling from JS.

We need to distribute the scrolling from point X to point Y through multiple frames in our code. Definitely a nice thing to have.

@benignant
Copy link

...So, are we going to get smooth scrolling?

@alexdima alexdima added the feature-request Request for new features or functionality label May 26, 2016
@alexdima
Copy link
Member

I think this is a good opportunity for a PR:

@hediet
Copy link
Member

hediet commented Jun 9, 2016

Why not using the CSS property "transition-duration" for that? Seems to work quite well at first glance - if the lines that get invisible wouldn't disappear before the transition-duration is over.
I am not sure how important smooth scrolling is when translate3d is not used (and thus transition-duration has no effect).

@darkon5
Copy link

darkon5 commented Mar 9, 2017

Is this issue still active?

@nicolafio
Copy link
Contributor

@darkon5 I tried the latest master. Smooth scrolling seems to be working with the touchpad now (wohoo), but it still does not seem to work with the mouse wheel (tested on SP4 running Debian Stretch).

@nicolafio
Copy link
Contributor

I submitted a pull request that should fix this.

untitled2

@darkon5
Copy link

darkon5 commented May 9, 2017

@Jd342 HERO! <3

@alexdima alexdima added this to the June 2017 milestone Jun 6, 2017
@alexdima alexdima added the editor-core Editor basic functionality label Jun 6, 2017
@alexdima alexdima modified the milestones: On Deck, June 2017 Jun 28, 2017
@alexdima alexdima modified the milestones: August 2017, On Deck Aug 28, 2017
@alexdima alexdima mentioned this issue Aug 28, 2017
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-core Editor basic functionality feature-request Request for new features or functionality on-testplan
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants