Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect rendering of ascii escape sequences in REPL #4664

Closed
eightvans opened this issue Mar 25, 2016 · 3 comments
Closed

Incorrect rendering of ascii escape sequences in REPL #4664

eightvans opened this issue Mar 25, 2016 · 3 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Milestone

Comments

@eightvans
Copy link

  • VSCode Version: 0.10.11
  • OS Version:Windows 10 version 1511

Steps to Reproduce:

  1. Write to the REPL window using a string with an ascii escape sequence indicating both color and boldness as parameters e.g. '\u001b[35;1mmagentabold'
  2. Either bold or text color work separately but they do not work together. Nor are the escape sequences properly removed from the output.

A repo showing the problem can be seen here https://github.com/eightvans/asciiescape
A comment in replViewer.ts references this link http://ascii-table.com/ansi-escape-sequences.php showing how the sequence should be parsed.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Mar 28, 2016
@isidorn isidorn added this to the April 2016 milestone Mar 29, 2016
@daviwil
Copy link
Contributor

daviwil commented Apr 13, 2016

Do escape sequences for text colors currently work? I was under the impression that this wasn't implemented yet.

@isidorn
Copy link
Contributor

isidorn commented Apr 13, 2016

@daviwil yes we support escape sequences. This issue demonstrates that we do not support 2 escape sequences applyied to the same token at once.
@eightvans the issue is that we do not respect ';' in anscii escape codes. The code is a bit tricky and I will add this feature if more users ask for it

@isidorn isidorn added feature-request Request for new features or functionality and removed bug Issue identified by VS Code Team member as probable bug labels Apr 13, 2016
@isidorn isidorn modified the milestones: Backlog, April 2016 Apr 13, 2016
@isidorn isidorn removed their assignment Apr 13, 2016
@isidorn isidorn added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 17, 2017
@vscodebot
Copy link

vscodebot bot commented Nov 17, 2017

This issue has been closed because it is already tracked by another issue. See also our GitHub issues to search for existing issues and our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Nov 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues *duplicate Issue identified as a duplicate of another issue(s) feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

4 participants