Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension deprecation and redirection #4772

Closed
Tyriar opened this issue Mar 29, 2016 · 38 comments
Closed

Add extension deprecation and redirection #4772

Tyriar opened this issue Mar 29, 2016 · 38 comments
Assignees
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality marketplace Microsoft VS Code Marketplace issues on-testplan upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 29, 2016

Allow extensions to specify they are deprecated in their package.json, with an optional alternative extension(s) field. This setting can inform the user of the deprecation in-product, and if specified, potentially update to the new extension automatically without informing of the deprecation?

Related: #3670

@Tyriar Tyriar added feature-request Request for new features or functionality debt Code quality issues extensions Issues concerning extensions labels Mar 29, 2016
@be5invis
Copy link
Contributor

Any progress? I'd like to rename my extension be5invis.julia into be5invis.syntax-julia, but the old one cannot be removed.

@joaomoreno
Copy link
Member

cc @egamma This could be an alternative for renaming.

@egamma
Copy link
Member

egamma commented Jun 22, 2016

@joaomoreno yes, but this would still have the statistics issue in that the download count is now accounted to 2 extensions. For a not yet popular extension this is not an issue, but for a popular one it is. So I still think we need support for this from the market place.

@joaomoreno
Copy link
Member

@modigrv Is there any concept of deprecation?

@modigrv
Copy link

modigrv commented Jul 7, 2016

Forwarded the request to Marketplace PM

@hamenon
Copy link

hamenon commented Jul 8, 2016

@joaomoreno We don't have the concept of deprecation yet in the Marketplace. But we do intend to support it soon. The fact the extension is deprecated will be added to the extension properties. And the current plan is to not show deprecated extensions on the marketplace in searches etc, to prevent future installs. Will work with Wade on how to handle it on the client side.

@Tyriar
Copy link
Member Author

Tyriar commented Oct 5, 2016

@waderyan @hamenon any movement here?

@waderyan
Copy link

waderyan commented Oct 5, 2016

There has been some work here. #10551

@Tyriar
Copy link
Member Author

Tyriar commented Oct 5, 2016

Oh cool, is it planned to look into a deprecated extension automatically installing another extension that supersedes it? These are the use cases I'm aware of:

  • Abandoning an extension (could also use vsce unpublish?)
  • An extension is deprecated in favor of another publisher's (chrisdias.vscodeEditorConfig -> EditorConfig.EditorConfig)
  • An extension being renamed within the same publisher (be5invis.julia -> be5invis.syntax-julia)

It's not clear after skimming #10551 whether users are informed about the deprecation of they're just hidden from search.

@waderyan
Copy link

waderyan commented Oct 5, 2016

We punted on the use cases you described for now. We had to get the filter in for the search query, but should look at solving the cases you describe.

@Jaimeloeuf
Copy link

Hello, been some time, just wanted to check what is the status of this if anyone is kind enough to give some feedback? Thanks!

@RandomFractals
Copy link

RandomFractals commented Oct 2, 2020

much needed with the number of deprecated extensions in vscode marketplace growing and getting in the way of search and filtering.

We need 20 upvotes for this issue to get added to the backlog and be revisited by the vscode team.

P.S.: @misolori I like the proposed UX in #10551

@Jaimeloeuf
Copy link

@RandomFractals seems like more then 20 upvotes already for sometime it seems but nth much from core team, this would be really good to have!

@RandomFractals
Copy link

@Jaimeloeuf well, I did my job rallying the ext. dev troops in dev community slack to get us over 20 upvotes for this to be added to backlog.

The rest is up to @eamodio & vscode team to decide on when this gets implemented and released.

There are a lot of 'deprecated' extensions in vs marketplace that just get in a way of search & other things just confusing devs trying to find good extensions to use.

@jasonwilliams
Copy link
Contributor

jasonwilliams commented Dec 7, 2021

Man do we really need this.

I need to move an old extension to a new organisation (as the former maintainer left and want to use a new name/user). But sadly I can’t do it, looks like I’m going to have to duplicate it. The issue with that is the old one will still be top for probably years🙁

It also means the marketplace is a mess.

i filled out a survey on the marketplace last year and this was my top concern, this issue also has a lot of votes.

CC @chgill-MSFT

@Tyriar
Copy link
Member Author

Tyriar commented Dec 7, 2021

FYI @isidorn, this would help get rid of the extensions with titles containing "deprecated" in searches.

@chrisraygill
Copy link

Thanks for the feedback everyone!

Right now the Marketplace team is engaged in an effort to completely rebuild the backend infrastructure. This will entail positive changes to organization management, extension ownership, deprecation experiences, and more.

While it's difficult to give a firm delivery date - we can expect the ability to deprecate extensions will be an outcome of this effort in the near future.

To get an idea of how this might look in the future, you can see the nuget.org package deprecation docs.

To build on what @Tyriar said, the goal of deprecation would be the following:

  1. Make it clear to users which packages are up-to-date and actively maintained
  2. Enable publishers to suggest alterative extensions

At this time, it's still unclear how deprecation may factor into search ranking or how indicators may appear in the VS Code client - however I'll be happy to use this thread to review ideas and get community feedback 🙂

@isidorn isidorn added marketplace Microsoft VS Code Marketplace issues and removed extensions Issues concerning extensions labels Dec 8, 2021
@isidorn isidorn added this to the Backlog milestone Dec 8, 2021
@isidorn isidorn added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 8, 2021
@isidorn
Copy link
Contributor

isidorn commented Mar 31, 2022

@RandomFractals thanks for sharing your concern, we will make sure to give extension authors enough time to reply. Possibly even a whole month.
We are doing this because a lot of extensions are in a really abandoned state = so the extension authors are no longer checking their email associated with the extension. So if we had to wait on confirmation of extension authors a lot of deprecated extensions we could not mark as such.
We will of course use this approach responsibly.

@fwouts
Copy link

fwouts commented Mar 31, 2022

In the meantime, if you have any extensions that are deprecated feel free to share them in this issue.

zenclabs.reactpreview is deprecated in favour of zenclabs.previewjs :) Thanks!

@sandy081 sandy081 self-assigned this Apr 11, 2022
@sandy081 sandy081 added the extensions Issues concerning extensions label Apr 11, 2022
@isidorn
Copy link
Contributor

isidorn commented Apr 25, 2022

Initial exploration and design has been done. Moving to next milestone when we will start looking into the implementation on the VS Code side.

@burkeholland
Copy link

Browser Preview is deprecated : https://marketplace.visualstudio.com/items?itemName=auchenberg.vscode-browser-preview

@isidorn
Copy link
Contributor

isidorn commented May 23, 2022

Thanks to the great work done by @sandy081 this is now done.

Try it out in VS Code insiders and let us know what you think.
Also please comment here if there are any deprecated extensions which we did not mark as deprecated yet. Thanks!

I still plan to update our extension author docs to explain extension deprecation.

Here's an example of how this looks like:

Screenshot 2022-05-23 at 14 02 03

Screenshot 2022-05-23 at 14 05 29

@isidorn isidorn closed this as completed May 23, 2022
@lnicola
Copy link
Contributor

lnicola commented May 23, 2022

@Isidon isidorn small, drive-by nit: that message at the bottom should probably say "Use the Live Preview extension instead.".

@isidorn
Copy link
Contributor

isidorn commented May 23, 2022

@lnicola thanks! I am not 100% convinced - but I am not a native English speaker :)
Maybe "Use Live Preview instead". So we remove "extension" part

@sandy081 what do you think?

@Tyriar
Copy link
Member Author

Tyriar commented May 23, 2022

@isidorn the current sentence sounds wrong to me but either proposal sounds natural. I'd go with Use Live Preview instead since "extension" is mentioned in the previous sentence already.

@mjbvz
Copy link
Collaborator

mjbvz commented May 23, 2022

@isidorn Are there any plans to (gently) alert users who already have a deprecated extension installed? Right now I find it easy to miss unless you are explicitly looking for it

@isidorn
Copy link
Contributor

isidorn commented May 24, 2022

@mjbvz yes, more details here #150011
@Tyriar thanks, I see Sandy has pushed a change with your proposal.

@RandomFractals
Copy link

RandomFractals commented May 24, 2022

@mjbvz & @isidorn: perhaps adding the deprecated extensions list to the welcome/getting started view when vscode IDE is updated could be a good solution to highlight deprecated extensions with alternatives to install and use instead, or migrate to via the new migrate feature you proposed in #150011

@isidorn
Copy link
Contributor

isidorn commented May 24, 2022

@RandomFractals thanks for the idea. Something to consider.
Though right now we are leaning towards having everything in the extensions viewlet / extension details scope.

@RandomFractals
Copy link

@isidorn my suggestion was mainly for the scenario @mjbvz described as many devs, us included, have and use many extensions and unless we go to extension view to review latest changes & updates, finding good up to date alternatives will be hidden. Could be another feature as you iterate on this ext. deprecation implementation later. I like the described experience so far. Thanks for taking it on!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
extensions Issues concerning extensions feature-request Request for new features or functionality marketplace Microsoft VS Code Marketplace issues on-testplan upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests