Changes in user launch configuration not picked up by debug dropdown

[isidorn]

Refs: #48423

Not sure if this was caused by refactoring so assigning to both of us.

1. Have a launch configuration in your user settings
2. Rename that launch configuration -> notice how the select drop down name is not updating

[isidorn]

I plan to investigate after I am done testing, so I can first look into it.

[weinand]

I'm pretty sure that I didn't touch anything in that area.

[weinand]

I'm stilling seeing the issue (on macOS and windows)

[isidorn]

I can reproduce this and the issue seems to be that I am not getting onDidChangeConfiguration from @sandy081 thus forwarding the issue to him.

Additional data:

1. If I change any other user setting I nicely get the event
2. Only if I change things inside the launch section in user settings I am not getting an event

I believe this was working 2 days ago, might it be that you changed something in the meantime?

[sandy081]

@isidorn I have not touched anything in this area this week. But assigning to April for investigation to check if something got broken.

[sandy081]

This was not working from the time fine grained configuration change events were introduced (atleast couple of milestones). Root cause is how settings are merged. We merge object types and replace the rest. Since configuration is of type array value get replaced and reports no effective change. Actually, different version of this problem has been there from the time user launches are introduced. Because ConfigurationService.getValue('launch') is never returning user launches as they are getting removed during merge. They are seen only when ConfigurationService.inspect is called.

@isidorn Not sure how important is to fix it in the end game week, I think the fix would be not trivial.

[sandy081]

Moving this as it is not important to fix.

[sandy081]

This is fixed now.