Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Views contributed to containers that don't exist don't error #48582

Closed
sbatten opened this issue Apr 24, 2018 · 3 comments
Closed

Views contributed to containers that don't exist don't error #48582

sbatten opened this issue Apr 24, 2018 · 3 comments
Assignees
Labels
polish Cleanup and polish issue tree-views Extension tree view issues verified Verification succeeded
Milestone

Comments

@sbatten
Copy link
Member

sbatten commented Apr 24, 2018

Testing #48407

When an extension authors a new view and adds it to a non-existent view container, no error is logged. Instead they are just added to the Explorer view container.

@sandy081 sandy081 added polish Cleanup and polish issue tree-views Extension tree view issues labels Apr 25, 2018
@sandy081 sandy081 added this to the April 2018 milestone Apr 25, 2018
@sandy081
Copy link
Member

sandy081 commented Apr 25, 2018

Following warning will be shown in such cases

View container 'id' does not exist and all views registered to it will be added to 'Explorer'.

Edit: Warning is shown in console as it is meant for extension authors

@mjbvz mjbvz added the verification-found Issue verification failed label Apr 27, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented Apr 27, 2018

I still see this behavior in 6d7bb1a

For the contributions:

"contributes": {
    "views": {
      "nonesuch": [
        {
          "id": "myview",
          "name": "My View"
        }
      ]
    }
  },

no error and the view is added to the explorer:

screen shot 2018-04-26 at 7 57 01 pm

@mjbvz mjbvz reopened this Apr 27, 2018
@sandy081
Copy link
Member

@mjbvz Warning is shown in the console as it is meant for extension authors.

@sandy081 sandy081 removed the verification-found Issue verification failed label Apr 27, 2018
@RMacfarlane RMacfarlane added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants