Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organizeImports should respect tslint.json #49194

Closed
wiedikerli opened this issue May 4, 2018 · 1 comment
Closed

organizeImports should respect tslint.json #49194

wiedikerli opened this issue May 4, 2018 · 1 comment
Assignees
Labels
javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@wiedikerli
Copy link

It would be nice if the organizeImports would respect the settings in tslint.
If you have an import such as:

import {
    ActivatedRouteSnapshot,
    CanActivate,
    CanActivateChild,
    Router,
    RouterStateSnapshot
} from '@angular/router';

it will organize it as follows:

import { ActivatedRouteSnapshot, CanActivate, CanActivateChild, Router, RouterStateSnapshot } from '@angular/router';

The problem is that I have the tslint rule max-line-length set to 100 characters.

  • VSCode Version: 1.23.0
  • OS Version: Windows 8

Steps to Reproduce:

  1. Activate organizeImports
  2. Add tslint.json with the rule max-line-length: [true, 100]
  3. Save .ts file

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the new release label May 4, 2018
@mjbvz mjbvz self-assigned this May 4, 2018
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label May 4, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented May 4, 2018

Support for max-line-length is tracked by microsoft/TypeScript#22991

@mjbvz mjbvz closed this as completed May 4, 2018
@mjbvz mjbvz added typescript Typescript support issues javascript JavaScript support issues labels May 4, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
javascript JavaScript support issues typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants