Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webview persistence: Webview won't be reconstructed when reloading more than once #50748

Closed
octref opened this issue May 29, 2018 · 1 comment
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Milestone

Comments

@octref
Copy link
Contributor

octref commented May 29, 2018

#50696

I have a serializer like this registered:

  vscode.window.registerWebviewPanelSerializer(CatCodingPanel.viewType, {
    deserializeWebviewPanel(webviewPanel: vscode.WebviewPanel, state: any) {
      console.log(state)
      webviewPanel.webview.html = '<div>hi</div>'
      return Promise.resolve()
    }
  })

cat

@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label May 29, 2018
@mjbvz mjbvz added this to the May 2018 milestone May 29, 2018
@mjbvz
Copy link
Collaborator

mjbvz commented May 29, 2018

I believe this was fixed by 6e81adc

Marking as duplicate of #50752

@mjbvz mjbvz closed this as completed May 29, 2018
@mjbvz mjbvz added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels May 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

2 participants