Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add trigger character to SignatureHelpProvider #51731

Closed
mjbvz opened this issue Jun 12, 2018 · 1 comment
Closed

Add trigger character to SignatureHelpProvider #51731

mjbvz opened this issue Jun 12, 2018 · 1 comment
Assignees
Labels
api api-proposal editor-parameter-hints Function, method and class parameter hint widget

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 12, 2018

Problem
Some signature help providers need to know why they are triggered. See microsoft/TypeScript#24915 for more details on one use case

Proposal
Pass the triggerCharacter to the provideSignatureHelp call. This could be introduced in a context parameter at the end of the parameter list:

export interface SignatureHelpContext {
    triggerCharacter?: string;
}

export interface SignatureHelpProvider {

	provideSignatureHelp(document: TextDocument, position: Position, token: CancellationToken, context: SignatureHelpContext): ProviderResult<SignatureHelp>;
}
@mjbvz
Copy link
Collaborator Author

mjbvz commented Jul 24, 2018

Moving to more generic proposal: #54972

@mjbvz mjbvz closed this as completed Jul 24, 2018
@mjbvz mjbvz removed this from the August 2018 milestone Jul 24, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-proposal editor-parameter-hints Function, method and class parameter hint widget
Projects
None yet
Development

No branches or pull requests

2 participants