Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve sidebar optimal resizing #5320

Closed
2 tasks
mquandalle opened this issue Apr 15, 2016 · 2 comments
Closed
2 tasks

Improve sidebar optimal resizing #5320

mquandalle opened this issue Apr 15, 2016 · 2 comments
Labels
feature-request Request for new features or functionality
Milestone

Comments

@mquandalle
Copy link
Contributor

mquandalle commented Apr 15, 2016

I implemented sidebar optimal resizing in 65bdaf3. However some desirable characteristics of this feature were postponed due to some implementation challenges—namely, measuring not-yet-rendered DOM elements. I’m opening this issue to keep track of these sub-features with the hope that they will be solved at some point.


(originate from #4702 (comment))

  • getOptimalWidth() doesn’t work if the sidebar is closed, ie you can’t double click on the closed sash to open the sidebar to its optimal width, which is expected;
  • if the explorer list is too long, VSCode renderer will break the list into multiple “tiles” that won’t be displayed concurrently, thus getOptimalWidth() will only consider visible elements and not the entire list. For comparison, this is handled correctly by both Atom and SublimeText.
@bpasero
Copy link
Member

bpasero commented Apr 15, 2016

👍

@bpasero bpasero added feature-request Request for new features or functionality workbench labels Apr 15, 2016
@bpasero bpasero added this to the Backlog milestone Apr 15, 2016
@bpasero bpasero removed their assignment Aug 17, 2016
@bpasero
Copy link
Member

bpasero commented Nov 16, 2017

This feature request will not be considered in the next 6-12 months roadmap and as such will be closed to keep the number of issues we have to maintain actionable. Thanks for understanding and happy coding!

@bpasero bpasero closed this as completed Nov 16, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants