Extension host API should support custom close action in show*Message calls

[dbaeumer]

• VSCode Version: 1.0.0
• OS Version:

The API currently always adds a close message. I want to use my own wording.

[jrieken]

stretch for April

[jrieken]

We should have MessageOptions similar to how we have QuickPickOptions which allows to control this. Like

interface MessageOptions {
   excludeDefaultClose:boolean
}

[jrieken]

@dbaeumer What would you prefer, explicit MessageOptions or alternatively a property on the MessageItem signalling it replaces Close?

Historically, I added the close action by default such that there is always an affordance to close when no message items are present. So with the MessageOptions someone could say don't show close but also provide no alternative which isn't valid. Moving the replaces close information into the MessageItem avoids that problem but someone could set that on all items which is a little bogus. What do you think?

[jrieken]

spelled out

export interface MessageOptions {
 noClose: boolean;
}

export function showWarningMessage<T extends MessageItem>(message: string, options: MessageOptions, ...items: T[]): Thenable<T>;

// repeat for Info and Error...

or letting the MessageItem signal

export interface MessageItem {      
    title: string;
    isCloseAffordance?: boolean;
}

[dbaeumer]

I like the second better.

[jrieken]

deal