Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor should show "no results" when searching #55615

Closed
roblourens opened this issue Aug 2, 2018 · 4 comments · Fixed by #56868
Closed

Settings editor should show "no results" when searching #55615

roblourens opened this issue Aug 2, 2018 · 4 comments · Fixed by #56868
Assignees
@roblourens @miguelsolorio
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
August 2018

Comments

@roblourens
Copy link
Member

  • Do a search that returns no results
  • Weird empty screen
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues labels Aug 2, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 2, 2018
@deadcoder0904
Copy link

Glad that VSCode Bot works & provides relevant results otherwise I was opening same issue 😂

@roblourens roblourens mentioned this issue Aug 7, 2018
Closed
38 tasks
@roblourens
Copy link
Member Author

This is probably just bringing back this:
image

and adding a message like this:

image

@misolori let me know if you have any other thoughts for this

@miguelsolorio
Copy link
Contributor

@roblourens that's exactly what I had in mind, keep it simple/consistent

@JacksonKearl JacksonKearl self-assigned this Aug 14, 2018
@JacksonKearl JacksonKearl mentioned this issue Aug 21, 2018
Merged
@roblourens
Copy link
Member Author

image

👍

@RMacfarlane RMacfarlane added the verified Verification succeeded label Aug 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

@miguelsolorio miguelsolorio

Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

Successfully merging a pull request may close this issue.

Add a message showing no results in settigns search JacksonKearl/vscode
5 participants
@roblourens @RMacfarlane @JacksonKearl @deadcoder0904 @miguelsolorio