Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

settings UI: show deprecated settings when set #55646

Closed
aeschli opened this issue Aug 2, 2018 · 1 comment
Closed

settings UI: show deprecated settings when set #55646

aeschli opened this issue Aug 2, 2018 · 1 comment
Assignees
@roblourens
Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
August 2018

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 2, 2018

  • In the user settings add "scss.colorDecorators.enable": false,
  • The "scss.colorDecorators.enable" setting does not show the new settings editor.

scss.colorDecorators.enable is marked as deprecated. It is therefore hidden in code completion in settings.json, but gets a hover and a warning when used.

IMO the new settings editor should only show it when set and also show the deprecation warning.
@aeschli aeschli changed the title settings Ui: show deprecated settings when set settings UI: show deprecated settings when set Aug 2, 2018
@aeschli aeschli mentioned this issue Aug 2, 2018
Closed
@roblourens roblourens added the feature-request Request for new features or functionality label Aug 2, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 2, 2018
@roblourens roblourens added the settings-editor VS Code settings editor issues label Aug 2, 2018
@roblourens roblourens mentioned this issue Aug 4, 2018
Closed
38 tasks
@JacksonKearl JacksonKearl self-assigned this Aug 7, 2018
@JacksonKearl
Copy link
Contributor

Closed in #55977

@roblourens roblourens added the verification-needed Verification of issue is requested label Aug 28, 2018
@isidorn isidorn added the verified Verification succeeded label Aug 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
feature-request Request for new features or functionality settings-editor VS Code settings editor issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
August 2018
Development

No branches or pull requests
4 participants
@roblourens @isidorn @aeschli @JacksonKearl