Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugger doesnt stop when running extension from source and a new folder is opened #55899

Closed
ramya-rao-a opened this issue Aug 6, 2018 · 10 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues macos Issues with VS Code on MAC/OS X

Comments

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Aug 6, 2018

  • VSCode Version: 1.26 insiders
  • OS Version: Mac

Steps to Reproduce:

  1. Have an extension that opens a folder on command
vscode.commands.registerCommand('extension.sayHello', () => {
        vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse('file://Users/some-local-path'));
    })
  1. Debug the extension, run the above command
  2. Observe the folder we want to open is indeed opened. Close the VS Code window
  3. Back in the folder for the extension source itself, the debug session doesnt stop. The debug tool bar is still there. Clicking on the stop button does nothing.

In stable bits of 1.25.1, the debug session closes automatically.

@vscodebot vscodebot bot added the insiders label Aug 6, 2018
@ramya-rao-a ramya-rao-a added debug Debug viewlet, configurations, breakpoints, adapter issues candidate Issue identified as probable candidate for fixing in the next release labels Aug 6, 2018
@ramya-rao-a ramya-rao-a added this to the July 2018 milestone Aug 6, 2018
@weinand weinand assigned roblourens and unassigned isidorn Aug 6, 2018
@roblourens
Copy link
Member

roblourens commented Aug 6, 2018

I can't repro this, it attaches to the new EH like it should, and stop works.

@ramya-rao-a ramya-rao-a added macos Issues with VS Code on MAC/OS X bug Issue identified by VS Code Team member as probable bug labels Aug 6, 2018
@weinand
Copy link
Contributor

weinand commented Aug 6, 2018

Same here. Cannot reproduce.

@roblourens
Copy link
Member

roblourens commented Aug 6, 2018

I do see the problem on Ramya's mac. After the new window opens, the debugger attaches correctly, and the DA sends initialized, but vscode never sends the requests that should happen at this point, so we get "The extension host did not start in 10 seconds..."

@ramya-rao-a
Copy link
Contributor Author

vscode-node-debug2.txt

@weinand
Copy link
Contributor

weinand commented Aug 6, 2018

@roblourens please see my comment #55911 (comment)

@roblourens
Copy link
Member

Is terminate involved here?

@weinand
Copy link
Contributor

weinand commented Aug 6, 2018

Yes, Ramyas initial comment says: "Clicking on the stop button does nothing"

@roblourens
Copy link
Member

It's broken before that point

@weinand
Copy link
Contributor

weinand commented Aug 6, 2018

Most likely this is the same as #55025

@roblourens
Copy link
Member

Oh ok, that sounds right. I guess I'm not sure why it works most of the time.

@roblourens roblourens removed this from the July 2018 milestone Aug 6, 2018
@roblourens roblourens removed bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release labels Aug 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues macos Issues with VS Code on MAC/OS X
Projects
None yet
Development

No branches or pull requests

4 participants