Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inform extensions that call 'vscode.openFolder' with file URIs created with URI.parse #57267

Closed
9 of 17 tasks
aeschli opened this issue Aug 27, 2018 · 0 comments
Closed
9 of 17 tasks
Assignees
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verified Verification succeeded
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Aug 27, 2018

Looking at the source code of extensions on the Marketplace, we found the following extension that seem to use the 'vscode.openFolder' command with an invalid file URI.

When creating a URI from a file path, always use vscode.URI.file(path), e.g vscode.URI.file('c:\\test')
Use vscode.URI.parse(uriString) when the input string is in the form scheme://authority/path

  • adstep.vscode-tmp/out/src/extension.js
    15,41: vscode.commands.executeCommand('vscode.openFolder', tempDirUri, true);
    no repo
  • basys.vscode-basys/src/extension.js
    49,45: await vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dirObj[0].path));
    Fix URI creation from path basys/vscode-basys#1
  • carlevans.remote-editor/out/old/addNew.js @carlevans719
    24,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    23,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    24,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    24,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    24,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    24,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    32,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dirPath), true);
    24,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    24,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir), true);
    no repo
  • cg-cnu.vscode-krita-plugin-generator/out/krita.js
    18,30: .executeCommand("vscode.openFolder", repoUri, newWindow)
    Fix URI creation from path cg-cnu/vscode-krita-plugin-generator#1
  • ckampfe.logbook/out/extension.js @ckampfe
    55,47: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(logbookDirectory), openInNewWindow // whether the logbook directory should open in a new window or not.
    no repo
  • cloudiotools.cloudio/src/cloudioCreateProject.js
    22,37: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(data.projectFolder));
    no repo
  • DavidHelmer.mavensmate/out/src/vscode/projectQuickPick.js
    24,50: return vscode_1.commands.executeCommand('vscode.openFolder', projectUri).then(null, console.error);
    no issue tracking FYI @joeferraro @kidtsunami
  • dphans.esp32-micropython/out/extension.js
    98,49: vscode.commands.executeCommand("vscode.openFolder", vscode.Uri.parse(selectedDir));
    *** privat repo *** FYI @dphans
  • dphans.micropython-ide-vscode/out/app/classes/getting-started/getting-started.js
    133,49: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(workingFolder));
    133,49: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(workingFolder));
    221,55: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(workingFolder));
    Fix URI creation from path dphans/micropython-ide-vscode#6
  • kalitaalexey.vscode-rust/out/src/components/cargo/cargo_manager.js
    373,53: vscode.commands.executeCommand('vscode.openFolder', uri, true);
    192,55: vscode_1.commands.executeCommand('vscode.openFolder', uri, true);
    Fix URI creation from path editor-rs/vscode-rust#385
  • matijarmk.dotnet-core-commands/out/commands/SDKCommands/newproject.js
    37,65: vscode.commands.executeCommand("vscode.openFolder", vscode.Uri.parse(folder[0].fsPath));
    Fix URI creation from path matijarmk/dotnet-core-commands#13
  • ms-dynamics-smb.al/out/src/services/bootstrapService.js
    57,45: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(dir));
    Fix URI creation from path AL#3467
  • NAVBaaS.git/out/commands/Go.js
    136,51: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(gitRepoFolder));
    27,51: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(gitRepoFolder));
    27,51: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(gitRepoFolder));
    Fix URI creation from path NAVBaaS/GitIntegration#16
  • salesforce.salesforcedx-vscode-core/out/src/commands/forceProjectCreate.js
    43,55: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(path.join(response.data.projectUri, response.data.projectName)));
    salesforce.salesforcedx-vscode-core/out/src/commands/isvdebugging/bootstrapCmd.js
    273,51: yield vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(projectPath));
    Fix URI creation from path forcedotcom/salesforcedx-vscode#600
  • Sencha.vscode-extjs/out/src/AppManager.js
    151,53: vscode.commands.executeCommand('vscode.openFolder', vscode.Uri.parse(location));
    *** no repo ***
  • tizensdk.tizentv/createProject.js
    325,34: vscode.commands.executeCommand('vscode.openFolder', uri);
    Release version 1.2.1 Samsung/vscode-extension-tizentv#12
  • wfnuser.vscode-ruff/out/src/extension.js
    87,53: vscode.commands.executeCommand('vscode.openFolder', uri);
    *** no repo ***
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

1 participant