Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: New version of Octicons #66229

Closed
3 tasks done
miguelsolorio opened this issue Jan 8, 2019 · 4 comments
Closed
3 tasks done

Test: New version of Octicons #66229

miguelsolorio opened this issue Jan 8, 2019 · 4 comments

Comments

@miguelsolorio
Copy link
Contributor

miguelsolorio commented Jan 8, 2019

Refs: #65508

Complexity: 2

We've updated our version of Octicons to the latest (3.1.0 => 8.3.0) and we've also added some additions/modifications (see #65989 for the full description). You should be able to use any Octicon as well as test our new additions: $(color-mode) $(organization) $(person). We also use Octicons in the following areas:

  • Status bar
  • Quick pick labels
  • Issue reporter (related issues)
  • Peek view (close button)
  • Extensions: workspace recommendations (viewlet header has download all and edit)
  • GitHub comment (edit and delete)
  • Diff line (show next/prev change)

Verify that the icons show up properly in each of those areas.

For the Status bar, you can create your own extension or use this basic one that cycles through all of the icons after you click the status bar item. You can additionally install other extensions that add items to the status bar (GitHub PR, vscide-spotify, Live Share, etc.) and verify that the icons show up correctly.

@isidorn
Copy link
Contributor

isidorn commented Jan 29, 2019

@misolori this works great, nice job.

@isidorn isidorn removed their assignment Jan 29, 2019
@roblourens roblourens removed their assignment Jan 29, 2019
@auchenberg
Copy link
Contributor

💥

@auchenberg auchenberg removed their assignment Jan 30, 2019
@Yzrsah
Copy link

Yzrsah commented Jan 31, 2019

Please post a documentation page with a visual key for all of the Octicons + VSCode additions. A table with names and icons.

@miguelsolorio
Copy link
Contributor Author

@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants