Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reveal = Never not respected when running task programmatically #66749

Closed
sergei-dyshel opened this issue Jan 18, 2019 · 1 comment
Closed

reveal = Never not respected when running task programmatically #66749

sergei-dyshel opened this issue Jan 18, 2019 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded

Comments

@sergei-dyshel
Copy link

  • VSCode Version: 1.30.2
  • OS Version: Linux

Run the following code as part of extension:

      const task = new vscode.Task(
          {type: 'myExt'}, vscode.workspace.workspaceFolders[0], 'myTask',
          'myExt', new vscode.ShellExecution('ls'));
      task.presentationOptions.reveal = vscode.TaskRevealKind.Never;
      vscode.tasks.executeTask(task);

Despite reveal = Never the terminal is still shown when executing task.

P.S. This is not a dup of similar recent issue because this happens also with Python extension disabled.
P.S.S. Looks similiar to old issue #19810;

@vscodebot vscodebot bot added the tasks Task system issues label Jan 18, 2019
@alexr00
Copy link
Member

alexr00 commented Jan 21, 2019

@sergei-dyshel, thank you for the example code. This only reproduces in stable. In insiders the issue is fixed already. Thank you for filing!

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Jan 21, 2019
@alexr00 alexr00 added this to the December/January 2019 milestone Jan 21, 2019
@alexr00 alexr00 closed this as completed Jan 21, 2019
@roblourens roblourens added the verified Verification succeeded label Feb 1, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants