Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function breakpoints should have glyphs #7262

Closed
edumunoz opened this issue Jun 6, 2016 · 3 comments
Closed

Function breakpoints should have glyphs #7262

edumunoz opened this issue Jun 6, 2016 · 3 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone

Comments

@edumunoz
Copy link
Contributor

edumunoz commented Jun 6, 2016

Currently, VSCode doesn't show any kind of graphical feedback of where function breakpoints have bound to.

Visual Studio and other IDEs show some graphical feedback to show the function breakpoint has bound to some specific locations / the debugger is in break mode at a particular line because of a function breakpoint.
It would be great for VSCode to support this in the case when debug adapters report the line(s) where the function breakpoint has been bound.

This helps users determine that

  • there is a breakpoint that will be hit at some locations
  • a breakpoint has been hit when stopped at a function breakpoint.

@weinand @isidorn

@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality labels Jun 6, 2016
@weinand weinand self-assigned this Jun 6, 2016
@weinand weinand added this to the Backlog milestone Jun 6, 2016
@isidorn
Copy link
Contributor

isidorn commented Oct 6, 2016

This sounds interesting to me. Especially since it would also solve our issue on how to add condition or hit counts to function breakpoints

@weinand weinand assigned isidorn and unassigned weinand Apr 6, 2017
@isidorn isidorn removed their assignment Apr 13, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 17, 2017

Somewhat a duplicate of #3388

@isidorn isidorn closed this as completed Nov 17, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 1, 2018
@weinand weinand modified the milestones: Backlog, February 2018 Feb 5, 2018
@weinand weinand reopened this Feb 5, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 14, 2018

In february we will tackle #3388 and as part of that we will show function breakpoint glyphs in the debug viewlet.

Showing function breakpoint glyphs in the editor margin is not possible since this is not supported by the debug adapter protocol, and I am not sure which debuggers could support this funcionality.

Since the first part of this issue is covered by another issue and the second part we do not plan to work on I have decided to close this issue.

@isidorn isidorn closed this as completed Feb 14, 2018
@isidorn isidorn removed the feature-request Request for new features or functionality label Feb 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Development

No branches or pull requests

3 participants