Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscode-test never returns on Linux #76126

Closed
Tyriar opened this issue Jun 25, 2019 · 3 comments
Closed

vscode-test never returns on Linux #76126

Tyriar opened this issue Jun 25, 2019 · 3 comments
Assignees
Labels
*as-designed Described behavior is as designed
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 25, 2019

#76039

Stuck in this state running the helloworld-test-sample:

image

@Tyriar Tyriar added this to the June 2019 milestone Jun 25, 2019
@octref
Copy link
Contributor

octref commented Jun 25, 2019

Yeah, I shouldn't have pushed the changes to samples until release I guess.

Current situation:

  • Stable can only handle function run(testsRoot: string, cb: (error: any, failures?: number) => void)
  • Insiders can handle both function run(testsRoot: string, cb: (error: any, failures?: number) => void) and function run(): Promise<void>.

So to fix this, you either need to rollback the test runner script: microsoft/vscode-extension-samples@a200f8f#diff-09fc88eb54dc89a6be596a48268514ea

Or you need to download Insiders to follow Test 2's step, download Insiders locally and use it as vscodeExecutablePath.

@octref
Copy link
Contributor

octref commented Jun 25, 2019

Closing as *as-designed. I'll update docs to mention that the new run signature is only supported from 1.36+.

@octref octref added the *as-designed Described behavior is as designed label Jun 25, 2019
@octref octref closed this as completed Jun 25, 2019
@vscodebot
Copy link

vscodebot bot commented Jun 25, 2019

The described behavior is how it is expected to work. If you disagree, please explain what is expected and what is not in more detail. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*as-designed Described behavior is as designed
Projects
None yet
Development

No branches or pull requests

2 participants