Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use service worker instead of registerBufferProtocol #77219

Closed
jrieken opened this issue Jul 11, 2019 · 1 comment
Closed

Use service worker instead of registerBufferProtocol #77219

jrieken opened this issue Jul 11, 2019 · 1 comment
Assignees
@jrieken
Labels
debt Code quality issues remote Remote system operations issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@jrieken
Copy link
Member

jrieken commented Jul 11, 2019 •
edited
Loading

Follow up for #75061

Today we use registerBufferProtocol to fetch resources that are using the vscode-remote-scheme. For the web companion we have a service worker based approach for that. Once electron/electron#19150 is fixed we should adopt the same solution for desktop
@jrieken jrieken self-assigned this Jul 11, 2019
@jrieken jrieken added debt Code quality issues electron-4.0.x-update remote Remote system operations issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jul 11, 2019
@jrieken
Copy link
Member Author

jrieken commented Oct 8, 2019

This isn't needed anymore

@jrieken jrieken closed this as completed Oct 8, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
debt Code quality issues remote Remote system operations issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jrieken