Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode incorrectly states comments aren't allowed in Windows Terminal profiles.json #78559

Closed
mikemaccana opened this issue Aug 6, 2019 · 2 comments
Closed

vscode incorrectly states comments aren't allowed in Windows Terminal profiles.json #78559

mikemaccana opened this issue Aug 6, 2019 · 2 comments
Assignees
@alexr00
Labels
feature-request Request for new features or functionality grammar Syntax highlighting grammar verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2019

Comments

@mikemaccana
Copy link

mikemaccana commented Aug 6, 2019 •
edited
Loading

Windows 10.0.18362.0, vscode 1.36.1, Terminal Preview 3.

vscode when editing it's own config (which allows comments in JSON)

image

vscode when editing Windows Terminal profiles.json (which allows comments in JSON )

image

vscode should not complain about the comments, when they are allowed (using whatever mechanism it uses to allow them in vscode's configs)
@mikemaccana mikemaccana changed the title vscode incorrectly states comments aren't allowed Windows Terminal settings.json vscode incorrectly states comments aren't allowed in Windows Terminal settings.json Aug 6, 2019
@mikemaccana mikemaccana changed the title vscode incorrectly states comments aren't allowed in Windows Terminal settings.json vscode incorrectly states comments aren't allowed in Windows Terminal profiles.json Aug 6, 2019
@mikemaccana mikemaccana mentioned this issue Aug 6, 2019
Closed
@octref
Copy link
Contributor

octref commented Aug 6, 2019

You can use files.associations to make the file JSONC type instead of JSON.

@octref octref closed this as completed Aug 6, 2019
@octref octref added the *question Issue represents a question, should be posted to StackOverflow (VS Code) label Aug 6, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 20, 2019
@alexr00 alexr00 self-assigned this Oct 25, 2019
@alexr00 alexr00 added feature-request Request for new features or functionality grammar Syntax highlighting grammar and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Oct 25, 2019
@alexr00 alexr00 added this to the October 2019 milestone Oct 25, 2019
@alexr00 alexr00 reopened this Oct 25, 2019
@alexr00 alexr00 added the verification-needed Verification of issue is requested label Oct 28, 2019
@alexr00
Copy link
Member

alexr00 commented Oct 28, 2019

To verify, open a json file named profiles.json and confirm that the grammar allows comments.

@roblourens roblourens added the verified Verification succeeded label Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality grammar Syntax highlighting grammar verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
4 participants
@mikemaccana @roblourens @octref @alexr00