Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency on node-gyp alienates contributors from most of the worlds regions #87538

Closed
Entomy opened this issue Dec 21, 2019 · 4 comments
Closed
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@Entomy
Copy link

Entomy commented Dec 21, 2019

While trying to contribute to this project and running into problems as described in another unrelated issue report, I had come across this section of of the wiki.

Make sure your profile path only contains ASCII letters, e.g. John, otherwise it can lead to node-gyp usage problems (nodejs/node-gyp/issues#297)

ASCII is basically a subset of the Latin group of alphabets primarily oriented around English and not particularly well suited for representation of most Latin group languages. Furthermore, the Latin group comprises only one of eight total alphabet based language groups, with the others being Arabic, Aramaic, Armenian, Brahmi, Cyrillic, Georgian, and Greek. Furthermore, many groups of people do not use alphabet based languages, and instead rely on syllabaries, such as the Cherokee or Japanese, logosyllabaries, such as the Chinese, abugidas, such as many Canadian Aboriginals or Etheopian, and much more language writing systems.

I believe this dependency on outdated, anglocentric, and non-globalized software unfairly increases the barrier to contribution from most of the world's people. Creating a new user account solely to develop for one product, requiring switching between user accounts just to do so, leaving behind all user settings and user specific software, imposes a burden on people because of their primary language; something very obviously tied to race and nationality. Surely this project should be equally as easy to contribute to for everyone?

@Entomy
Copy link
Author

Entomy commented Dec 21, 2019

This isn't an attempt to troll given the recent controversy. I've seen first hand how these kinds of inconveniences can discourage non-English-primary-speakers such as in this instance.

@Xaekai
Copy link

Xaekai commented Dec 22, 2019

Technically, this problem lies in gyp directly, not node-gyp.
nodejs/node-gyp#297 (comment)

Someone made a patch and was told it should be sent to gyp directly and never bothered
nodejs/node-gyp#945 (comment)

Looks like the issue has been around for quite a while
https://bugs.chromium.org/p/gyp/issues/list?q=ascii%20latin&can=2

And it also looks like you can make your PRs directly on Github and googlebot facilitates them.
https://github.com/chromium/gyp/pulls

So this is something that could be fixed by any interested party without having to reinvent the project build system wheel yet again .

@Entomy
Copy link
Author

Entomy commented Dec 22, 2019

@Xaekai oh okay, thank you for the direction. I have some experience with implementing full Unicode support in libraries (a language runtime, in fact), so I can look into this.

@egamma egamma added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Dec 22, 2019
@egamma
Copy link
Member

egamma commented Dec 22, 2019

Closing as an upstream issue.

@egamma egamma closed this as completed Dec 22, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

4 participants