Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Have a setting for maximum number open files (editors) #89275

Closed
2 tasks done
bpasero opened this issue Jan 25, 2020 · 0 comments
Closed
2 tasks done

Test: Have a setting for maximum number open files (editors) #89275

bpasero opened this issue Jan 25, 2020 · 0 comments

Comments

@bpasero
Copy link
Member

bpasero commented Jan 25, 2020

Refs: #9872

Complexity: 3

This feature is not enabled by default and comes with 3 settings to enable:

  • workbench.editor.limit.enabled
  • workbench.editor.limit.perEditorGroup
  • workbench.editor.limit.value

Steps:

  • verify this setting makes sense when you read the description in settings editor
  • verify that the setting works as advertised once enabled
    • when you open a new editor, editors that are NOT dirty will close by least recently use
      • across all editor groups globally (workbench.editor.limit.perEditorGroup: false)
      • within a group locally (workbench.editor.limit.perEditorGroup: true)
    • the limit when to start closing is configurable via workbench.editor.limit.value
  • verify closing editors in LRU order works even after a restart
    • we preserve the recency of editor use in storage and restore it
  • verify that enabling this setting will already close editors directly
@bpasero bpasero added this to the January 2020 milestone Jan 25, 2020
@chrmarti chrmarti removed their assignment Jan 28, 2020
@Tyriar Tyriar removed their assignment Jan 28, 2020
@Tyriar Tyriar closed this as completed Jan 28, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants